third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp - Issue 2401123002: UserGestureIndicator is a mess. Clean it up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp

Issue 2401123002: UserGestureIndicator is a mess. Clean it up. (Closed)

Patch Set: Callback cleanup, comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp b/third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp

index 5e54eb96f2b0d58e930c8204d12bcb84b6db8b85..3122fe0eb6b52a170aadea06df676cecaa733037 100644

--- a/third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp

@@ -139,7 +139,7 @@ TEST_F(HTMLVideoElementTest, setBufferingStrategy_UserPause) {

EXPECT_CALL(*player, setBufferingStrategy(

WebMediaPlayer::BufferingStrategy::Aggressive));

{

- UserGestureIndicator gesture(DefinitelyProcessingUserGesture);

+ UserGestureIndicator gesture(UserGestureToken::create());

m_video->pause();

}

::testing::Mock::VerifyAndClearExpectations(player);