third_party/WebKit/Source/web/WebScopedUserGesture.cpp - Issue 2401123002: UserGestureIndicator is a mess. Clean it up.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/web/WebScopedUserGesture.cpp

Issue 2401123002: UserGestureIndicator is a mess. Clean it up. (Closed)

Patch Set: Callback cleanup, comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/web/WebPluginContainerImpl.cpp ('k') | third_party/WebKit/Source/web/WebUserGestureToken.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Google Inc. All rights reserved.	2 * Copyright (C) 2011 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 23 matching lines...) Expand all Loading...
34 #include "public/web/WebUserGestureToken.h"	34 #include "public/web/WebUserGestureToken.h"

35	35

36 namespace blink {	36 namespace blink {

37	37

38 WebScopedUserGesture::WebScopedUserGesture(const WebUserGestureToken& token) {	38 WebScopedUserGesture::WebScopedUserGesture(const WebUserGestureToken& token) {

39 if (!token.isNull())	39 if (!token.isNull())

40 m_indicator.reset(new UserGestureIndicator(token));	40 m_indicator.reset(new UserGestureIndicator(token));

41 }	41 }

42	42

43 WebScopedUserGesture::WebScopedUserGesture() {	43 WebScopedUserGesture::WebScopedUserGesture() {

44 m_indicator.reset(	44 m_indicator.reset(new UserGestureIndicator(

45 new UserGestureIndicator(DefinitelyProcessingNewUserGesture));	45 UserGestureToken::create(UserGestureToken::NewGesture)));

46 }	46 }

47	47

48 WebScopedUserGesture::~WebScopedUserGesture() {}	48 WebScopedUserGesture::~WebScopedUserGesture() {}

49	49

50 } // namespace blink	50 } // namespace blink

OLD	NEW