Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXObject.cpp

Issue 2401123002: UserGestureIndicator is a mess. Clean it up. (Closed)
Patch Set: Callback cleanup, comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 1329 matching lines...) Expand 10 before | Expand all | Expand 10 after
1340 } 1340 }
1341 1341
1342 // 1342 //
1343 // Modify or take an action on an object. 1343 // Modify or take an action on an object.
1344 // 1344 //
1345 1345
1346 bool AXObject::press() const { 1346 bool AXObject::press() const {
1347 Element* actionElem = actionElement(); 1347 Element* actionElem = actionElement();
1348 if (!actionElem) 1348 if (!actionElem)
1349 return false; 1349 return false;
1350 UserGestureIndicator gestureIndicator(DefinitelyProcessingNewUserGesture); 1350 UserGestureIndicator gestureIndicator(
1351 UserGestureToken::create(UserGestureToken::NewGesture));
1351 actionElem->accessKeyAction(true); 1352 actionElem->accessKeyAction(true);
1352 return true; 1353 return true;
1353 } 1354 }
1354 1355
1355 void AXObject::scrollToMakeVisible() const { 1356 void AXObject::scrollToMakeVisible() const {
1356 IntRect objectRect = pixelSnappedIntRect(getBoundsInFrameCoordinates()); 1357 IntRect objectRect = pixelSnappedIntRect(getBoundsInFrameCoordinates());
1357 objectRect.setLocation(IntPoint()); 1358 objectRect.setLocation(IntPoint());
1358 scrollToMakeVisibleWithSubFocus(objectRect); 1359 scrollToMakeVisibleWithSubFocus(objectRect);
1359 } 1360 }
1360 1361
(...skipping 372 matching lines...) Expand 10 before | Expand all | Expand 10 after
1733 } 1734 }
1734 1735
1735 DEFINE_TRACE(AXObject) { 1736 DEFINE_TRACE(AXObject) {
1736 visitor->trace(m_children); 1737 visitor->trace(m_children);
1737 visitor->trace(m_parent); 1738 visitor->trace(m_parent);
1738 visitor->trace(m_cachedLiveRegionRoot); 1739 visitor->trace(m_cachedLiveRegionRoot);
1739 visitor->trace(m_axObjectCache); 1740 visitor->trace(m_axObjectCache);
1740 } 1741 }
1741 1742
1742 } // namespace blink 1743 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698