Repositioning of the dimmer overlay when the shelf gets only moved and not resized.

Repositioning of the dimmer overlay when the shelf gets only moved and not resized.

The "dimmer" cannot be parented by the shelf, but it needs to overlay it. The existing OnBoundsChanged call will only detect size changes since the position relatively to its parent never changes. Therefore the shelf's window needs to be observed as well to get absolute location changes.

BUG=285415
TEST=visual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221804

[Mr4D (OOO till 08-26), 2013-09-05 22:56:57]

Please have a look!

[James Cook, 2013-09-05 23:41:00]

lgtm with nits

https://codereview.chromium.org/24011002/diff/1/ash/shelf/shelf_widget.cc
File ash/shelf/shelf_widget.cc (right):

https://codereview.chromium.org/24011002/diff/1/ash/shelf/shelf_widget.cc#new...
ash/shelf/shelf_widget.cc:279: // aura::WindowObserver overrides.
tiny nit: "overrides:" instead of "overrides."

https://codereview.chromium.org/24011002/diff/1/ash/shelf/shelf_widget.cc#new...
ash/shelf/shelf_widget.cc:450: // coming here the shelf got repositioned and
since the |dimmer_| is placed
nit: coming -> Coming

[Mr4D (OOO till 08-26), 2013-09-05 23:47:26]

Addressed! Many thanks!

https://codereview.chromium.org/24011002/diff/1/ash/shelf/shelf_widget.cc
File ash/shelf/shelf_widget.cc (right):

https://codereview.chromium.org/24011002/diff/1/ash/shelf/shelf_widget.cc#new...
ash/shelf/shelf_widget.cc:279: // aura::WindowObserver overrides.
Done

https://codereview.chromium.org/24011002/diff/1/ash/shelf/shelf_widget.cc#new...
ash/shelf/shelf_widget.cc:450: // coming here the shelf got repositioned and
since the |dimmer_| is placed
On 2013/09/05 23:41:00, James Cook wrote:
> nit: coming -> Coming

Done.

[commit-bot: I haz the power, 2013-09-05 23:49:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/24011002/6001

[commit-bot: I haz the power, 2013-09-06 01:02:57]

Retried try job too often on linux_chromeos for step(s) ash_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-09-06 03:11:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/24011002/6001

[commit-bot: I haz the power, 2013-09-06 04:13:21]

Retried try job too often on linux_chromeos for step(s) ash_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-09-06 16:24:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/24011002/43001

[commit-bot: I haz the power, 2013-09-06 19:54:38]

Retried try job too often on win7_aura for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-09-06 20:09:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/24011002/43001

[commit-bot: I haz the power, 2013-09-06 22:48:47]

Change committed as 221804