MD Settings: Ensure that long text does not overlap with <select> arrow.

MD Settings: Ensure that long text does not overlap with <select> arrow.

Thanks to @michaelpg for the suggestions.

BUG=653755
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/577dc9d546b6b77bb3ee2158e1aa4805d4f5adcd
Cr-Commit-Position: refs/heads/master@{#423971}

[dpapad, 2016-10-07 17:58:41]

Description was changed from

==========
MD Settings: Ensure that long text does not overlap with <select> arrow.

Thanks to @michaelpg for the suggestions.

BUG=653755
==========

to

==========
MD Settings: Ensure that long text does not overlap with <select> arrow.

Thanks to @michaelpg for the suggestions.

BUG=653755
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-10-07 18:01:12]

dpapad@chromium.org changed reviewers:
+ michaelpg@chromium.org

[dpapad, 2016-10-07 18:01:12]

Screenshot at http://imgur.com/a/Ed0Cz.

https://codereview.chromium.org/2401093002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/md_select_css.html (right):

https://codereview.chromium.org/2401093002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/md_select_css.html:9: -webkit-padding-end:
calc(0.9em * 1.8);
Increased to 1.8, because 1.5 still seemed overly close to the arrow.

[michaelpg, 2016-10-07 18:25:27]

neato, lgtm w/ suggestion

https://codereview.chromium.org/2401093002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/md_select_css.html (right):

https://codereview.chromium.org/2401093002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/md_select_css.html:9: -webkit-padding-end:
calc(0.9em * 1.8);
opt nit: make it harder to break

  --md-arrow-width: 0.9em;
  -webkit-padding-end: calc(var(--md-arrow-width) * 1.8);
  background-size: var(--md-arrow-width);

[dpapad, 2016-10-07 19:14:04]

https://codereview.chromium.org/2401093002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/md_select_css.html (right):

https://codereview.chromium.org/2401093002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/md_select_css.html:9: -webkit-padding-end:
calc(0.9em * 1.8);
On 2016/10/07 at 18:25:26, michaelpg wrote:
> opt nit: make it harder to break
> 
>   --md-arrow-width: 0.9em;
>   -webkit-padding-end: calc(var(--md-arrow-width) * 1.8);
>   background-size: var(--md-arrow-width);

Done.

[dpapad, 2016-10-07 19:17:28]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-10-07 19:17:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2401093002/#ps20001
(title: "Use var")

[commit-bot: I haz the power, 2016-10-07 19:18:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 21:33:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-07 21:36:10]

Description was changed from

==========
MD Settings: Ensure that long text does not overlap with <select> arrow.

Thanks to @michaelpg for the suggestions.

BUG=653755
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Ensure that long text does not overlap with <select> arrow.

Thanks to @michaelpg for the suggestions.

BUG=653755
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/577dc9d546b6b77bb3ee2158e1aa4805d4f5adcd
Cr-Commit-Position: refs/heads/master@{#423971}
==========

[commit-bot: I haz the power, 2016-10-07 21:36:11]

Patchset 2 (id:??) landed as
https://crrev.com/577dc9d546b6b77bb3ee2158e1aa4805d4f5adcd
Cr-Commit-Position: refs/heads/master@{#423971}