Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2401083003: [Sync] Adding integration tests for USS encryption and fixing a worker bug. (Closed)
Patch Set: Updates for Max. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « components/sync/test/engine/single_type_mock_server.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 73f04962b4d5dc45e500d66100c1be979fd4ef83..8fe91cb5f58da1c522888e0defbf6b672272e993 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -63573,6 +63573,19 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Sync.WorkerApplyHasEncryptedUpdates"
+ enum="BooleanHasEncryptedUpdates">
rkaplow 2016/10/20 17:31:10 nit, instead of a custom Boolean.. I would just us
skym 2016/10/20 18:38:04 Done.
+ <owner>skym@chromium.org</owner>
+ <summary>
+ During ApplyUpdates in the ModelTypeWorker (USS only), if there are still
+ encrypted updates, but the cryptographer has no pending keys. This state
rkaplow 2016/10/20 17:31:10 can you reword? This first sentance isn't making s
maxbogue 2016/10/20 18:12:46 I suggest "Whether there are still encrypted updat
skym 2016/10/20 18:38:04 Done.
skym 2016/10/20 18:38:04 Done.
+ should be extermely rare, due to a bug or inconsistent GetUpdates that
maxbogue 2016/10/20 18:12:46 extremely*
skym 2016/10/20 18:38:04 Done.
+ contain newly encrypted entities but not the update Nigori node. Having
+ encrypted updates at this point in the sync cycle is an invalid state, and
+ has the potential to cause a loss of user data.
+ </summary>
+</histogram>
+
<histogram name="Sync.YoungestForeignTabAgeOnNTP" units="seconds">
<owner>skym@chromium.org</owner>
<summary>Upon NTP load, the age of the youngest synced foreign tab.</summary>
@@ -74355,6 +74368,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="1" label="Has distilled data"/>
</enum>
+<enum name="BooleanHasEncryptedUpdates" type="int">
+ <int value="0" label="No encrypted updates"/>
+ <int value="1" label="Has encrypted updates"/>
+</enum>
+
<enum name="BooleanHasPath" type="int">
<int value="0" label="No path"/>
<int value="1" label="Has path"/>
« no previous file with comments | « components/sync/test/engine/single_type_mock_server.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698