Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 2401043003: Move the setting of bindings code generator up the stack. (Closed)

Created:
4 years, 2 months ago by dglazkov
Modified:
4 years, 1 month ago
Reviewers:
haraken, bashi, Yuki
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the setting of bindings code generator up the stack. This opens the path for cleanly switching different types of code generators. Also eliminates the need for IdlCompilerV8 and IdlCompilerDictionaryImpl. R=bashi,yukishiino BUG=654129 Committed: https://crrev.com/28e4cd6cdb271055f445717508ebea7595fa4676 Cr-Commit-Position: refs/heads/master@{#424070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -52 lines) Patch
M third_party/WebKit/Source/bindings/scripts/idl_compiler.py View 5 chunks +23 lines, -44 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py View 3 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
dglazkov
PTAL.
4 years, 2 months ago (2016-10-08 04:07:32 UTC) #5
haraken
LGTM
4 years, 2 months ago (2016-10-08 04:41:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401043003/1
4 years, 2 months ago (2016-10-08 04:45:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-08 04:51:19 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/28e4cd6cdb271055f445717508ebea7595fa4676 Cr-Commit-Position: refs/heads/master@{#424070}
4 years, 2 months ago (2016-10-08 04:52:59 UTC) #11
bashi
4 years, 2 months ago (2016-10-10 23:06:06 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698