Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: chrome/installer/linux/BUILD.gn

Issue 2401033003: Fix gn installer/linux/BUILD.gn with target_arch=arm (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/linux/BUILD.gn
diff --git a/chrome/installer/linux/BUILD.gn b/chrome/installer/linux/BUILD.gn
index fcc2d753fad79d4979df45495f45ce918ad4eabd..c6c9eba73216de64899a771ad37aa5a01b30c849 100644
--- a/chrome/installer/linux/BUILD.gn
+++ b/chrome/installer/linux/BUILD.gn
@@ -238,7 +238,7 @@ template("linux_package") {
packaging_files_binaries += [ "$root_out_dir/nacl_irt_arm.nexe" ]
}
- if (is_chrome_branded) {
+ if (is_chrome_branded && (current_cpu == "x86" || current_cpu == "x64")) {
ddorwin 2016/10/07 22:37:52 You might explain this in a comment. For example,
Sam Clegg 2016/10/07 22:51:48 Done.
packaging_files_binaries += [
"$root_out_dir/$widevine_cdm_path/libwidevinecdmadapter.so",
ddorwin 2016/10/07 22:37:52 I wonder if this should be the output of the build
xhwang 2016/10/07 22:51:27 I was following other examples in this file and I
Sam Clegg 2016/10/07 22:51:48 Sounds like a good idea, but something for another
"$root_out_dir/$widevine_cdm_path/libwidevinecdm.so",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698