Chromium Code Reviews

Issue 240103002: Use StrictTypeChecking for ImageBitmap (Closed)

Created:
6 years, 8 months ago by fs
Modified:
6 years, 8 months ago
Reviewers:
Justin Novosad
CC:
blink-reviews
Visibility:
Public.

Description

Use StrictTypeChecking for ImageBitmap Add [StrictTypeChecking] to the 'ImageBitmapFactories' interface and the 'Window' partial interface. This doesn't change behavior in practice, but signals that it has been considered. Drop the unnecessary null-checks in the implementation. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171790

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+6 lines, -28 lines)
M LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args.html View 1 chunk +1 line, -0 lines 0 comments
M LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args-expected.txt View 1 chunk +1 line, -0 lines 0 comments
M LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args-in-workers-expected.txt View 1 chunk +1 line, -0 lines 0 comments
M LayoutTests/fast/canvas/resources/canvas-createImageBitmap-invalid-args-in-workers.js View 1 chunk +1 line, -0 lines 0 comments
M Source/modules/imagebitmap/ImageBitmapFactories.cpp View 7 chunks +0 lines, -28 lines 0 comments
M Source/modules/imagebitmap/ImageBitmapFactories.idl View 1 chunk +1 line, -0 lines 0 comments
M Source/modules/imagebitmap/WindowImageBitmapFactories.idl View 1 chunk +1 line, -0 lines 0 comments

Messages

Total messages: 9 (0 generated)
fs
6 years, 8 months ago (2014-04-16 09:04:38 UTC) #1
Justin Novosad
On 2014/04/16 09:04:38, fs wrote: lgtm
6 years, 8 months ago (2014-04-16 17:01:30 UTC) #2
fs
The CQ bit was checked by fs@opera.com
6 years, 8 months ago (2014-04-16 17:20:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/240103002/1
6 years, 8 months ago (2014-04-16 17:21:18 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-16 17:49:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 8 months ago (2014-04-16 17:49:37 UTC) #6
fs
The CQ bit was checked by fs@opera.com
6 years, 8 months ago (2014-04-16 17:50:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/240103002/1
6 years, 8 months ago (2014-04-16 17:50:23 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 18:02:31 UTC) #9
Message was sent while issue was closed.
Change committed as 171790

Powered by Google App Engine