Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html

Issue 2401013002: Make MediaSession per frame as an attribute of Navigator (Closed)
Patch Set: fixed tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html
diff --git a/third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html b/third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html
index 083f56608fa73ce3e25caad01c8c898a284ee619..5bac9d1670e56fcd0e0062167d07ea1353431a2e 100644
--- a/third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html
+++ b/third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html
@@ -3,60 +3,59 @@
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<script>
- console.warn("dummy log entry to avoid an empty -expected.txt in virtual/");
-
- test(function() {
- var metadata = new MediaMetadata({});
- assert_true(metadata != null);
-
- var exception = false;
- try {
- metadata = new MediaMetadata("foobar");
- } catch (e) {
- exception = true;
- }
- assert_true(exception);
-
- exception = false;
- try {
- metadata = new MediaMetadata(42);
- } catch (e) {
- exception = true;
- }
- assert_true(exception);
- }, 'Test that MediaMetadata is constructed using a dictionary');
-
- test(function() {
- var metadata = new MediaMetadata({
- title: 'foo', album: 'bar', artist: 'plop',
- artwork: [ { src: 'src1', sizes: 'sizes1', type: 'type1'},
- { src: 'src2', sizes: 'sizes2', type: 'type2'} ] });
- assert_equals(metadata.title, 'foo');
- assert_equals(metadata.album, 'bar');
- assert_equals(metadata.artist, 'plop');
- assert_equals(2, metadata.artwork.length);
-
- var image1 = new MediaImage({ src: 'src1', sizes: 'sizes1', type: 'type1'});
- var image2 = new MediaImage({ src: 'src2', sizes: 'sizes2', type: 'type2'});
- assert_equals(metadata.artwork[0].src, image1.src);
- assert_equals(metadata.artwork[0].sizes, image1.sizes);
- assert_equals(metadata.artwork[0].type, image1.type);
- assert_equals(metadata.artwork[1].src, image2.src);
- assert_equals(metadata.artwork[1].sizes, image2.sizes);
- assert_equals(metadata.artwork[1].type, image2.type);
- }, 'Test the different values allowed in MediaMetadata init dictionary');
-
- test(function() {
- var metadata = new MediaMetadata({});
- assert_equals(metadata.title, '');
- assert_equals(metadata.artist, '');
- assert_equals(metadata.album, '');
- assert_equals(0, metadata.artwork.length);
- }, 'Test the default values for MediaMetadata');
-
- test(function() {
- var metadata = new MediaMetadata({ randomValueThatWillNotBeAdded: '... hopefully ;)' });
- assert_equals(metadata.randomValueThatWillNotBeAdded, undefined);
- }, 'Test that passing unknown values to the dictionary is a no-op');
+
+test(function() {
+ var metadata = new MediaMetadata({});
+ assert_true(metadata != null);
mlamouri (slow - plz ping) 2016/10/10 20:30:34 as above, assert_not_equals?
Zhiqiang Zhang (Slow) 2016/10/11 10:56:04 Done.
+
+ var exception = false;
+ try {
+ metadata = new MediaMetadata("foobar");
+ } catch (e) {
+ exception = true;
+ }
+ assert_true(exception);
+
+ exception = false;
+ try {
+ metadata = new MediaMetadata(42);
+ } catch (e) {
+ exception = true;
+ }
+ assert_true(exception);
+}, 'Test that MediaMetadata is constructed using a dictionary');
+
+test(function() {
+ var metadata = new MediaMetadata({
+ title: 'foo', album: 'bar', artist: 'plop',
+ artwork: [ { src: 'src1', sizes: 'sizes1', type: 'type1'},
+ { src: 'src2', sizes: 'sizes2', type: 'type2'} ] });
+ assert_equals(metadata.title, 'foo');
+ assert_equals(metadata.album, 'bar');
+ assert_equals(metadata.artist, 'plop');
+ assert_equals(2, metadata.artwork.length);
+
+ var image1 = new MediaImage({ src: 'src1', sizes: 'sizes1', type: 'type1'});
+ var image2 = new MediaImage({ src: 'src2', sizes: 'sizes2', type: 'type2'});
+ assert_equals(metadata.artwork[0].src, image1.src);
+ assert_equals(metadata.artwork[0].sizes, image1.sizes);
+ assert_equals(metadata.artwork[0].type, image1.type);
+ assert_equals(metadata.artwork[1].src, image2.src);
+ assert_equals(metadata.artwork[1].sizes, image2.sizes);
+ assert_equals(metadata.artwork[1].type, image2.type);
+}, 'Test the different values allowed in MediaMetadata init dictionary');
+
+test(function() {
+ var metadata = new MediaMetadata({});
+ assert_equals(metadata.title, '');
+ assert_equals(metadata.artist, '');
+ assert_equals(metadata.album, '');
+ assert_equals(0, metadata.artwork.length);
+}, 'Test the default values for MediaMetadata');
+
+test(function() {
+ var metadata = new MediaMetadata({ randomValueThatWillNotBeAdded: '... hopefully ;)' });
+ assert_equals(metadata.randomValueThatWillNotBeAdded, undefined);
+}, 'Test that passing unknown values to the dictionary is a no-op');
whywhat 2016/10/10 20:45:09 looks like an accidental formatting change to me t
Zhiqiang Zhang (Slow) 2016/10/11 10:56:03 Reverted
</script>

Powered by Google App Engine
This is Rietveld 408576698