third_party/WebKit/Source/modules/mediasession/NavigatorMediaSession.idl - Issue 2401013002: Make MediaSession per frame as an attribute of Navigator

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/mediasession/NavigatorMediaSession.idl

Issue 2401013002: Make MediaSession per frame as an attribute of Navigator (Closed)

Patch Set: fixed tests Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/mediasession/NavigatorMediaSession.cpp ('K') | « third_party/WebKit/Source/modules/mediasession/NavigatorMediaSession.cpp ('k') | third_party/WebKit/Source/modules/modules_idl_files.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://github.com/WICG/web-share/blob/master/docs/interface.md	5 // https://wicg.github.io/mediasession/#the-mediasession-interface

6	6

7 [	7 [

8 OriginTrialEnabled=WebShare,	8 Exposed=(Window),
	whywhat 2016/10/10 20:45:10 What does this mean? What does this mean? Zhiqiang Zhang (Slow) 2016/10/11 10:56:04 This means the partial interface is available to W Show quoted text On 2016/10/10 20:45:10, whywhat wrote: > What does this mean? This means the partial interface is available to Window and not Worker. We do not want workers use our API. whywhat 2016/10/11 14:58:33 Hm, we don't have that on Presentation I think, sh Show quoted text On 2016/10/11 at 10:56:04, Zhiqiang Zhang wrote: > On 2016/10/10 20:45:10, whywhat wrote: > > What does this mean? > > This means the partial interface is available to Window and not Worker. We do not want workers use our API. Hm, we don't have that on Presentation I think, should we add that there (Mounir?)
	9 RuntimeEnabled=MediaSession

9 ] partial interface Navigator {	10 ] partial interface Navigator {

10 [CallWith=ScriptState, MeasureAs=WebShareShare]	11 readonly attribute MediaSession mediaSession;

11 Promise<void> share(ShareData data);

12 };	12 };

OLD	NEW