Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1829)

Side by Side Diff: third_party/WebKit/LayoutTests/media/mediasession/resources/utils.js

Issue 2401013002: Make MediaSession per frame as an attribute of Navigator (Closed)
Patch Set: fixed tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 function assert_image_equals(expected, observed) {
2 assert_equals(expected.src, observed.src);
3 assert_equals(expected.type, observed.type);
4 assert_equals(expected.sizes, observed.sizes);
5 }
6
7 function assert_metadata_equals(expected, observed) {
8 assert_equals(expected.title, observed.title);
9 assert_equals(expected.artist, observed.artist);
10 assert_equals(expected.album, observed.album);
11 assert_equals(expected.artwork.length, observed.artwork.length);
12 for (var i = 0; i < expected.artwork.length; i++) {
mlamouri (slow - plz ping) 2016/10/10 20:30:34 style: you can drop { }
Zhiqiang Zhang (Slow) 2016/10/11 10:56:04 Done.
13 assert_image_equals(expected.artwork[i], observed.artwork[i]);
14 }
15 }
16
17 function mojoString16ToJS(mojoString16) {
18 return String.fromCharCode.apply(this, mojoString16.data);
whywhat 2016/10/10 20:45:09 nit: seems like everywhere else null is passed as
Zhiqiang Zhang (Slow) 2016/10/11 10:56:04 Done.
19 }
20
21 function mojoImageToJS(mojoImage) {
22 var src = mojoImage.src.url;
23 var type = mojoString16ToJS(mojoImage.type);
24 var sizes = "";
25 for (var i = 0; i < mojoImage.sizes.length; i++) {
26 if (i > 0) {
mlamouri (slow - plz ping) 2016/10/10 20:30:34 style: ditto
Zhiqiang Zhang (Slow) 2016/10/11 10:56:04 Done.
27 sizes = sizes + " ";
whywhat 2016/10/10 20:45:09 nit: +=
Zhiqiang Zhang (Slow) 2016/10/11 10:56:04 Done.
28 }
29 var mojoSize = mojoImage.sizes[i];
30 sizes = sizes + mojoSize.width.toString() + "x" + mojoSize.height.toString() ;
whywhat 2016/10/10 20:45:09 nit: ditto
Zhiqiang Zhang (Slow) 2016/10/11 10:56:04 Done.
31 }
32 return { src: src, type: type, sizes: sizes };
33 }
34
35 function mojoMetadataToJS(mojoMetadata) {
36 var title = mojoString16ToJS(mojoMetadata.title);
37 var artist = mojoString16ToJS(mojoMetadata.artist);
38 var album = mojoString16ToJS(mojoMetadata.album);
39 var artwork = [];
40 for (var i = 0; i < mojoMetadata.artwork.length; i++) {
mlamouri (slow - plz ping) 2016/10/10 20:30:34 style: ditto
Zhiqiang Zhang (Slow) 2016/10/11 10:56:04 Done.
41 artwork.push(mojoImageToJS(mojoMetadata.artwork[i]));
42 }
43 return new MediaMetadata({title: title, artist: artist, album: album, artwork: artwork});
44 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698