scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json - Issue 2400963002: Fix file.copy recipe_module to not fail if files are already equal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json

Issue 2400963002: Fix file.copy recipe_module to not fail if files are already equal. (Closed)

Patch Set: all expectations, omg! Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipes/chromium.expected/full_chromium_lkgr_ASAN_Release.json ('K') | « scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json ('k') | scripts/slave/recipes/cronet.expected/android_cronet_data_reduction_proxy_builder.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json

diff --git a/scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json b/scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json

index 75b1706e902190fed3c1e1f73e78b41afac2f825..268c31b8bbe5f828868ace2338c704151e1c1a9a 100644

--- a/scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json

+++ b/scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json

@@ -752,7 +752,7 @@

"cmd": [

"python",

"-u",

- "\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",

+ "\nimport shutil\nimport sys\n# Apparently, shutil.copy fails if files are binary-equal on *nix OSes.\n# See http://crbug.com/636168#c8.\nif hasattr(shutil, '_samefile'):\n if shutil._samefile(sys.argv[1], sys.argv[2]):\n sys.exit(0)\nshutil.copy(sys.argv[1], sys.argv[2])\n",

"[SLAVE_BUILD]/src/chrome/VERSION",

"/path/to/tmp/"