Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: scripts/slave/recipe_modules/file/api.py

Issue 2400963002: Fix file.copy recipe_module to not fail if files are already equal. (Closed)
Patch Set: all expectations, omg! Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/file/api.py
diff --git a/scripts/slave/recipe_modules/file/api.py b/scripts/slave/recipe_modules/file/api.py
index 60ff2ead17c223ab68098eeb467cbaf2a3363e3e..80a3230e6df6a0bda5422d6f226b667a95c8e100 100644
--- a/scripts/slave/recipe_modules/file/api.py
+++ b/scripts/slave/recipe_modules/file/api.py
@@ -18,6 +18,11 @@ class FileApi(recipe_api.RecipeApi):
"""
import shutil
import sys
+ # Apparently, shutil.copy fails if files are binary-equal on *nix OSes.
+ # See http://crbug.com/636168#c8.
+ if hasattr(shutil, '_samefile'):
+ if shutil._samefile(sys.argv[1], sys.argv[2]):
+ sys.exit(0)
shutil.copy(sys.argv[1], sys.argv[2])
""",
args=[source, dest],

Powered by Google App Engine
This is Rietveld 408576698