Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2400953003: Add browser test for NavigationMetricsRecorder (Closed)

Created:
4 years, 2 months ago by meacer
Modified:
4 years, 1 month ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add browser test for NavigationMetricsRecorder BUG=652381 Committed: https://crrev.com/bc7f7e92f3c0c6d307e637d150da7dff613b1bcb Cr-Commit-Position: refs/heads/master@{#430988}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -5 lines) Patch
M chrome/browser/tab_contents/navigation_metrics_recorder.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/navigation_metrics_recorder.cc View 3 chunks +10 lines, -5 lines 0 comments Download
A chrome/browser/tab_contents/navigation_metrics_recorder_browsertest.cc View 1 chunk +56 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
meacer
avi: PTAL? Thanks.
4 years, 1 month ago (2016-11-09 01:01:58 UTC) #11
Avi (use Gerrit)
lgtm
4 years, 1 month ago (2016-11-09 15:47:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400953003/20001
4 years, 1 month ago (2016-11-09 18:28:55 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-09 18:36:15 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 18:47:08 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bc7f7e92f3c0c6d307e637d150da7dff613b1bcb
Cr-Commit-Position: refs/heads/master@{#430988}

Powered by Google App Engine
This is Rietveld 408576698