Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2400943002: bluetooth: Reject with NetworkError when disconnected during getPrimaryService(s) (Closed)

Created:
4 years, 2 months ago by ortuno
Modified:
4 years, 2 months ago
Reviewers:
Jeffrey Yasskin
CC:
blink-reviews, chromium-reviews, haraken, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Reject with NetworkError when disconnected during getPrimaryService(s) https://webbluetoothcg.github.io/web-bluetooth/#connection-checking-wrapper says to replace the real error with a NetworkError if we've disconnected during the operation. We get there through the https://webbluetoothcg.github.io/web-bluetooth/#query-the-bluetooth-cache step of https://webbluetoothcg.github.io/web-bluetooth/#getgattchildren. BUG=608538 Committed: https://crrev.com/890c0e885e07c0a1843df8f9f38b10eb56a83867 Cr-Commit-Position: refs/heads/master@{#424360}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -325 lines) Patch
D third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/device-disconnects-during.html View 1 chunk +0 lines, -26 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/device-disconnects-during-error.html View 1 chunk +9 lines, -7 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/device-disconnects-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/device-reconnects-during.html View 1 chunk +0 lines, -22 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/device-reconnects-during-error.html View 1 chunk +4 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/device-reconnects-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/disconnect-called-during.html View 1 chunk +0 lines, -21 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/disconnect-called-during-error.html View 1 chunk +4 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/disconnect-called-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/reconnect-during.html View 1 chunk +0 lines, -22 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/reconnect-during-error.html View 1 chunk +5 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/reconnect-during-success.html View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/device-disconnects-during.html View 1 chunk +0 lines, -26 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/device-disconnects-during-error-with-uuid.html View 2 chunks +5 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/device-disconnects-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/device-disconnects-during-success-with-uuid.html View 1 chunk +2 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/device-disconnects-during-with-uuid.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/device-reconnects-during.html View 1 chunk +0 lines, -22 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/device-reconnects-during-error-with-uuid.html View 1 chunk +5 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/device-reconnects-during-success.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/device-reconnects-during-success-with-uuid.html View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/device-reconnects-during-with-uuid.html View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/disconnect-called-during.html View 1 chunk +0 lines, -22 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/disconnect-called-during-error-with-uuid.html View 1 chunk +4 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/disconnect-called-during-success.html View 1 chunk +2 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/disconnect-called-during-success-with-uuid.html View 1 chunk +2 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/disconnect-called-during-with-uuid.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/reconnect-during.html View 1 chunk +0 lines, -22 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/reconnect-during-error-with-uuid.html View 1 chunk +5 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/reconnect-during-success.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/reconnect-during-success-with-uuid.html View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/reconnect-during-with-uuid.html View 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ortuno
jyasskin: PTAL. Fixes some comments you made in http://crrev.com/2387293008 Also adds tests.
4 years, 2 months ago (2016-10-07 04:47:46 UTC) #4
Jeffrey Yasskin
lgtm
4 years, 2 months ago (2016-10-10 20:48:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400943002/1
4 years, 2 months ago (2016-10-11 00:27:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 03:21:28 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 03:26:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/890c0e885e07c0a1843df8f9f38b10eb56a83867
Cr-Commit-Position: refs/heads/master@{#424360}

Powered by Google App Engine
This is Rietveld 408576698