CoreAnimation: Fix text anti-aliasing in download shelf

CoreAnimation: Fix text anti-aliasing in download shelf

Make the download shelf buttons opaque, and have them use the download
shelf's draw function to draw.

Add a helper function to look up an ancestor view based on the view ID.
This is particularly useful because the download shelf is five views
above the download shelf button view.

Update the bookmark button view function to refer to the toolbar view
as the download shelf toolbar view (which does not have a view ID
associated with it).

BUG=363750
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264363

[ccameron, 2014-04-16 19:17:55]

Small fix, usual scheme.

https://codereview.chromium.org/240093006/diff/1/chrome/browser/ui/cocoa/book...
File chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm (right):

https://codereview.chromium.org/240093006/diff/1/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm:413: -
(void)drawRect:(NSRect)rect {
I kept trying to change this to use VIEW_ID_TOOLBAR, only to find that it wasn't
the toolbar I wasn't looking for (the bookmark bar toolbar doesn't have an ID).

[Avi (use Gerrit), 2014-04-16 19:57:56]

lgtm

[ccameron, 2014-04-16 20:11:19]

Thanks!

[ccameron, 2014-04-16 20:11:24]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-04-16 20:12:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/240093006/20001

[commit-bot: I haz the power, 2014-04-17 00:19:04]

Change committed as 264363