skia/ext/platform_surface.h - Issue 2400873002: keep only one typedef for the native drawing context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: skia/ext/platform_surface.h

Issue 2400873002: keep only one typedef for the native drawing context (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: skia/ext/platform_surface.h

diff --git a/skia/ext/platform_surface.h b/skia/ext/platform_surface.h

index 793bf649b64ba85f72968a51ef82e2205d01ea5d..fa69c05fe1544961594865821a26f8c8ab5a8819 100644

--- a/skia/ext/platform_surface.h

+++ b/skia/ext/platform_surface.h

@@ -23,16 +23,16 @@ typedef struct CGRect CGRect;

namespace skia {

#if defined(OS_WIN)

-typedef HDC PlatformSurface;

+typedef HDC NativeDrawingContext;

typedef RECT PlatformRect;

#elif defined(USE_CAIRO)

-typedef cairo_t* PlatformSurface;

+typedef cairo_t* NativeDrawingContext;

tomhudson 2016/10/07 06:10:14 Misspelled - this shouldn't build on Linux?

tomhudson 2016/10/07 06:12:34 Never mind, my laptop screen was dirty. No wonder

typedef cairo_rectangle_t PlatformRect;

#elif defined(OS_MACOSX)

-typedef CGContextRef PlatformSurface;

+typedef CGContextRef NativeDrawingContext;

typedef CGRect PlatformRect;

#else

-typedef void* PlatformSurface;

+typedef void* NativeDrawingContext;

typedef SkIRect* PlatformRect;

#endif

« no previous file with comments | « skia/ext/platform_device_win.cc ('k') | skia/ext/skia_utils_mac.mm » ('j') | no next file with comments »