Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2400863003: [wasm] Simd128 types should not be available in asmjs modules. (Closed)

Created:
4 years, 2 months ago by gdeepti
Modified:
4 years, 2 months ago
Reviewers:
titzer, bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Simd128 types should not be available in asmjs modules. - Added gating code in the module-decoder to allow SIMD code only when it can be decoded correctly - SIMD128 values should not be exported to JS - Try/Catch should not be available in asmjs modules - Trivial fixes for S128 values BUG=chromium:648079 R=ahaas@chromium.org, titzer@chromium.org, bradnelson@chromium.org Committed: https://crrev.com/19dab886a4013761fa9266fd21fd755a172cd3eb Cr-Commit-Position: refs/heads/master@{#40067}

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -6 lines) Patch
M src/compiler/wasm-compiler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/wasm-compiler.cc View 4 chunks +8 lines, -3 lines 0 comments Download
M src/wasm/ast-decoder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/wasm/ast-decoder.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/wasm/module-decoder.cc View 2 chunks +7 lines, -1 line 0 comments Download
A test/mjsunit/regress/wasm/regression-648079.js View 1 1 chunk +324 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/wasm-constants.js View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
gdeepti
4 years, 2 months ago (2016-10-07 03:01:32 UTC) #7
gdeepti
4 years, 2 months ago (2016-10-07 03:01:34 UTC) #8
bradnelson
lgtm
4 years, 2 months ago (2016-10-07 04:56:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400863003/20001
4 years, 2 months ago (2016-10-07 04:56:44 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/25879)
4 years, 2 months ago (2016-10-07 05:01:51 UTC) #15
titzer
On 2016/10/07 05:01:51, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 2 months ago (2016-10-07 07:44:11 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400863003/20001
4 years, 2 months ago (2016-10-07 07:48:29 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 07:52:11 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 07:52:28 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/19dab886a4013761fa9266fd21fd755a172cd3eb
Cr-Commit-Position: refs/heads/master@{#40067}

Powered by Google App Engine
This is Rietveld 408576698