Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2400853002:
[MD Feedback] Change paper-input placeholders to values. (Closed)
|
Created:
4 years, 2 months ago by apacible Modified:
4 years, 2 months ago Reviewers:
afakhry CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, apacible+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD Feedback] Change paper-input placeholders to values.
Currently, the info populated in the dialog is added to the paper-input as placeholders, which means they're not actually used as values. This change updates them to become paper-input values.
BUG=656025
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/e335ea7842bbffb12bd326aa3a4661eb0927065d
Cr-Commit-Position: refs/heads/master@{#425357}
Patch Set 1 #
Messages
Total messages: 18 (12 generated)
Description was changed from ========== switch placeholder to value BUG= ========== to ========== switch placeholder to value BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by apacible@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== switch placeholder to value BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD Feedback] Change paper-input placeholders to values. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [MD Feedback] Change paper-input placeholders to values. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD Feedback] Change paper-input placeholders to values. Currently, the info populated in the dialog is added to the paper-input as placeholders, which means they're not actually used as values. This change updates them to become paper-input values. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
apacible@chromium.org changed reviewers: + afakhry@chromium.org
PTAL, thanks!
lgtm! I suggest you create a top-level bug for "Creating an MD feedback UI" and all other sub-bugs and smaller tasks that are part of this big effort are blocking that top-level bug.
Description was changed from ========== [MD Feedback] Change paper-input placeholders to values. Currently, the info populated in the dialog is added to the paper-input as placeholders, which means they're not actually used as values. This change updates them to become paper-input values. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD Feedback] Change paper-input placeholders to values. Currently, the info populated in the dialog is added to the paper-input as placeholders, which means they're not actually used as values. This change updates them to become paper-input values. BUG=656025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
On 2016/10/12 16:42:33, afakhry wrote: > lgtm! > > I suggest you create a top-level bug for "Creating an MD feedback UI" and all > other sub-bugs and smaller tasks that are part of this big effort are blocking > that top-level bug. Done. Thanks!
The CQ bit was checked by apacible@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [MD Feedback] Change paper-input placeholders to values. Currently, the info populated in the dialog is added to the paper-input as placeholders, which means they're not actually used as values. This change updates them to become paper-input values. BUG=656025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD Feedback] Change paper-input placeholders to values. Currently, the info populated in the dialog is added to the paper-input as placeholders, which means they're not actually used as values. This change updates them to become paper-input values. BUG=656025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [MD Feedback] Change paper-input placeholders to values. Currently, the info populated in the dialog is added to the paper-input as placeholders, which means they're not actually used as values. This change updates them to become paper-input values. BUG=656025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD Feedback] Change paper-input placeholders to values. Currently, the info populated in the dialog is added to the paper-input as placeholders, which means they're not actually used as values. This change updates them to become paper-input values. BUG=656025 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e335ea7842bbffb12bd326aa3a4661eb0927065d Cr-Commit-Position: refs/heads/master@{#425357} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e335ea7842bbffb12bd326aa3a4661eb0927065d Cr-Commit-Position: refs/heads/master@{#425357} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
