Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2400823002: [asm.js] [wasm] Move asm->wasm + WebAssembly switches to features. (Closed)

Created:
4 years, 2 months ago by bradnelson
Modified:
4 years, 2 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[asm.js] [wasm] Move asm->wasm + WebAssembly switches to features. Moving asm->wasm and webassembly to a feature will make them ready to control from a Finch trial with kill-switch. NOTE: This will mean --enable-wasm will be replaced with: --enable-features=WebAssembly and --enable-asm-wasm will be replaced with: --enable-features=AsmJsToWebAssembly BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 R=asvitkine@chromium.org,jam@chromium.org,titzer@chromium.org,mtrofin@chromium.org Committed: https://crrev.com/c79f5a6f7563346a02c0ef03ae1a449a00da6dec Cr-Commit-Position: refs/heads/master@{#424193}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : disabled by default #

Patch Set 4 : fix #

Patch Set 5 : merge #

Total comments: 2

Patch Set 6 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -18 lines) Patch
M chrome/browser/about_flags.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
M content/child/runtime_features.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_features.h View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 2 3 4 2 chunks +10 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/render_process_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/enable_wasm/README.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/enable_wasm/http/tests/wasm/README.txt View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (23 generated)
bradn
4 years, 2 months ago (2016-10-06 22:30:08 UTC) #4
Alexei Svitkine (slow)
lgtm % comment https://codereview.chromium.org/2400823002/diff/80001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2400823002/diff/80001/tools/metrics/histograms/histograms.xml#oldcode88602 tools/metrics/histograms/histograms.xml:88602: - <int value="1174088940" label="enable-wasm"/> Keep the ...
4 years, 2 months ago (2016-10-07 15:12:47 UTC) #17
bradn
https://codereview.chromium.org/2400823002/diff/80001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2400823002/diff/80001/tools/metrics/histograms/histograms.xml#oldcode88602 tools/metrics/histograms/histograms.xml:88602: - <int value="1174088940" label="enable-wasm"/> On 2016/10/07 15:12:46, Alexei Svitkine ...
4 years, 2 months ago (2016-10-07 19:09:35 UTC) #18
jam
rs lgtm
4 years, 2 months ago (2016-10-10 15:43:09 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400823002/100001
4 years, 2 months ago (2016-10-10 16:36:28 UTC) #26
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 2 months ago (2016-10-10 18:35:58 UTC) #28
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 18:36:58 UTC) #30
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/c79f5a6f7563346a02c0ef03ae1a449a00da6dec
Cr-Commit-Position: refs/heads/master@{#424193}

Powered by Google App Engine
This is Rietveld 408576698