[Media Router] Remove desktop capture prompts.

Updates desktop_capture_access_handler to bypass prompts for external
components (including the Media Router) when the capture id is obtained
through the capture picker.

Simplify the logic for determining which desktop capture requests are
default approved.

Update desktop capture resource strings to remove references to
the Google Cast extension.

BUG=567443
Committed: https://crrev.com/382a7a5e909abcfd3e57f8a5176c2c38e69aa983
Cr-Commit-Position: refs/heads/master@{#424476}

[mark a. foltz, 2016-10-07 19:15:39]

Description was changed from

==========
Updates desktop_capture_access_handler to bypass prompts for external components
(including the Media Router) when the capture id is obtained through the capture
picker.

It also attempts to simplify the logic for determining which desktop capture
requests are default approved.

Finally it updates desktop capture resource strings to remove references to the
Google Cast extension.

BUG=567443
==========

to

==========
Updates desktop_capture_access_handler to bypass prompts for external
components (including the Media Router) when the capture id is obtained
through the capture picker.

It also attempts to simplify the logic for determining which desktop capture
requests are default approved.

Finally it updates desktop capture resource strings to remove references to
the Google Cast extension.

BUG=567443
==========

[mark a. foltz, 2016-10-07 19:21:35]

The CQ bit was checked by mfoltz@chromium.org to run a CQ dry run

[mark a. foltz, 2016-10-07 19:21:43]

mfoltz@chromium.org changed reviewers:
+ miu@chromium.org, sergeyu@chromium.org

[commit-bot: I haz the power, 2016-10-07 19:22:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mark a. foltz, 2016-10-07 19:22:27]

Description was changed from

==========
Updates desktop_capture_access_handler to bypass prompts for external
components (including the Media Router) when the capture id is obtained
through the capture picker.

It also attempts to simplify the logic for determining which desktop capture
requests are default approved.

Finally it updates desktop capture resource strings to remove references to
the Google Cast extension.

BUG=567443
==========

to

==========
Updates desktop_capture_access_handler to bypass prompts for external
components (including the Media Router) when the capture id is obtained
through the capture picker.

It simplifies the logic for determining which desktop capture requests are
default approved.

Finally it updates desktop capture resource strings to remove references to
the Google Cast extension.

BUG=567443
==========

[mark a. foltz, 2016-10-07 19:22:54]

Description was changed from

==========
Updates desktop_capture_access_handler to bypass prompts for external
components (including the Media Router) when the capture id is obtained
through the capture picker.

It simplifies the logic for determining which desktop capture requests are
default approved.

Finally it updates desktop capture resource strings to remove references to
the Google Cast extension.

BUG=567443
==========

to

==========
Updates desktop_capture_access_handler to bypass prompts for external
components (including the Media Router) when the capture id is obtained
through the capture picker.

Simplify the logic for determining which desktop capture requests are
default approved.

Update desktop capture resource strings to remove references to
the Google Cast extension.

BUG=567443
==========

[commit-bot: I haz the power, 2016-10-07 20:44:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 20:44:36]

Dry run: This issue passed the CQ dry run.

[miu, 2016-10-09 03:00:09]

lgtm

https://codereview.chromium.org/2400803003/diff/40001/chrome/browser/media/we...
File chrome/browser/media/webrtc/desktop_capture_access_handler.cc (right):

https://codereview.chromium.org/2400803003/diff/40001/chrome/browser/media/we...
chrome/browser/media/webrtc/desktop_capture_access_handler.cc:289: // Some
extensions do not require user approval.
Consider adding: "because they already provide the user-approval UI."

[Sergey Ulanov, 2016-10-10 17:56:16]

lgtm when my comment is addressed

https://codereview.chromium.org/2400803003/diff/40001/chrome/browser/media/we...
File chrome/browser/media/webrtc/desktop_capture_access_handler.cc (right):

https://codereview.chromium.org/2400803003/diff/40001/chrome/browser/media/we...
chrome/browser/media/webrtc/desktop_capture_access_handler.cc:342: bool
DesktopCaptureAccessHandler::IsDefaultApproved(
does this need to be a class method instead of just a static function?

[mark a. foltz, 2016-10-11 16:14:21]

On 2016/10/09 at 03:00:09, miu wrote:
> lgtm
> 
>
https://codereview.chromium.org/2400803003/diff/40001/chrome/browser/media/we...
> File chrome/browser/media/webrtc/desktop_capture_access_handler.cc (right):
> 
>
https://codereview.chromium.org/2400803003/diff/40001/chrome/browser/media/we...
> chrome/browser/media/webrtc/desktop_capture_access_handler.cc:289: // Some
extensions do not require user approval.
> Consider adding: "because they already provide the user-approval UI."

Done.

[mark a. foltz, 2016-10-11 16:15:00]

On 2016/10/10 at 17:56:16, sergeyu wrote:
> lgtm when my comment is addressed
> 
>
https://codereview.chromium.org/2400803003/diff/40001/chrome/browser/media/we...
> File chrome/browser/media/webrtc/desktop_capture_access_handler.cc (right):
> 
>
https://codereview.chromium.org/2400803003/diff/40001/chrome/browser/media/we...
> chrome/browser/media/webrtc/desktop_capture_access_handler.cc:342: bool
DesktopCaptureAccessHandler::IsDefaultApproved(
> does this need to be a class method instead of just a static function?

It calls a static protected method of the base class; converted to static.

[mark a. foltz, 2016-10-11 16:55:01]

The CQ bit was checked by mfoltz@chromium.org

[mark a. foltz, 2016-10-11 16:55:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyu@chromium.org, miu@chromium.org
Link to the patchset: https://codereview.chromium.org/2400803003/#ps80001
(title: "Reboase")

[commit-bot: I haz the power, 2016-10-11 16:55:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 17:43:07]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-11 17:46:14]

Description was changed from

==========
Updates desktop_capture_access_handler to bypass prompts for external
components (including the Media Router) when the capture id is obtained
through the capture picker.

Simplify the logic for determining which desktop capture requests are
default approved.

Update desktop capture resource strings to remove references to
the Google Cast extension.

BUG=567443
==========

to

==========
Updates desktop_capture_access_handler to bypass prompts for external
components (including the Media Router) when the capture id is obtained
through the capture picker.

Simplify the logic for determining which desktop capture requests are
default approved.

Update desktop capture resource strings to remove references to
the Google Cast extension.

BUG=567443

Committed: https://crrev.com/382a7a5e909abcfd3e57f8a5176c2c38e69aa983
Cr-Commit-Position: refs/heads/master@{#424476}
==========

[commit-bot: I haz the power, 2016-10-11 17:46:15]

Patchset 5 (id:??) landed as
https://crrev.com/382a7a5e909abcfd3e57f8a5176c2c38e69aa983
Cr-Commit-Position: refs/heads/master@{#424476}