Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: tests/lib/mirrors/parameter_test.dart

Issue 24008002: Merge tests for dart2js and VM using multi-tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/lib/mirrors/parameter_test.dart
diff --git a/tests/lib/mirrors/parameter_test.dart b/tests/lib/mirrors/parameter_test.dart
index 7c538a773bf4b489e26420c77237b94aa0218a0c..4abd0cd7d27cee25f57768bf76acf4bf9efe0fe4 100644
--- a/tests/lib/mirrors/parameter_test.dart
+++ b/tests/lib/mirrors/parameter_test.dart
@@ -2,7 +2,13 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-/// Test of [ParameterMirror].
+// This tests uses the multi-test "ok" feature:
+// none: Desired behaviour, passing on the VM.
+// 01: Trimmed version for dart2js.
+//
+// TODO(rmacnak,ahe): Remove multi-test when VM and dart2js are on par.
+
+/** Test of [ParameterMirror]. */
library test.parameter_test;
@MirrorsUsed(targets: 'test.parameter_test', override: '*')
@@ -65,6 +71,9 @@ main() {
expect('Class(s(B) in s(test.parameter_test), top-level)',
barConstructor.returnType);
+ // dart2js stops testing here.
+ return; /// 01: ok
+
MethodMirror bazConstructor = constructors[const Symbol('B.baz')];
expect('Method(s(B.baz) in s(B), constructor)', bazConstructor);
expect('[Parameter(s(x) in s(B.baz), final,'
« tests/lib/mirrors/equality_test.dart ('K') | « tests/lib/mirrors/parameter_dart2js_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698