Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: tests/lib/mirrors/equality_test.dart

Issue 24008002: Merge tests for dart2js and VM using multi-tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/mirrors/equality_dart2js_test.dart ('k') | tests/lib/mirrors/parameter_dart2js_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/equality_test.dart
diff --git a/tests/lib/mirrors/equality_test.dart b/tests/lib/mirrors/equality_test.dart
index 1a08b599fa2d06f1470fee9fb327ce7d0afea961..f5fe18cd78b06af8ad9c29b7bdcb75e975a3cdfd 100644
--- a/tests/lib/mirrors/equality_test.dart
+++ b/tests/lib/mirrors/equality_test.dart
@@ -2,6 +2,13 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+// This tests uses the multi-test "ok" feature:
+// none: Trimmed behaviour. Passing on the VM.
+// 01: Trimmed version for dart2js.
+// 02: Full version passing in the VM.
+//
+// TODO(rmacnak,ahe): Remove multi-test when VM and dart2js are on par.
+
library test.class_equality_test;
import 'dart:mirrors';
@@ -88,9 +95,11 @@ main() {
{'reflect("foo")' : reflect("foo"),
'reflect("foo"), again' : reflect("foo")},
- {'currentMirrorSystem().voidType' : currentMirrorSystem().voidType,
- 'thisLibrary.functions[#subroutine].returnType' :
- thisLibrary.functions[const Symbol('subroutine')].returnType},
+ {'currentMirrorSystem().voidType' : currentMirrorSystem().voidType}, /// 01: ok
Michael Lippautz (Google) 2013/09/05 22:49:49 Please, have mercy :)
+
+ {'currentMirrorSystem().voidType' : currentMirrorSystem().voidType, /// 02: ok
+ 'thisLibrary.functions[#subroutine].returnType' : /// 02: ok
+ thisLibrary.functions[const Symbol('subroutine')].returnType}, /// 02: ok
{'currentMirrorSystem().dynamicType' : currentMirrorSystem().dynamicType,
'thisLibrary.functions[#main].returnType' :
@@ -101,8 +110,8 @@ main() {
'reflect(new A<int>()).type.originalDeclaration' :
reflect(new A<int>()).type.originalDeclaration},
- {'reflectClass(B).superclass' : reflectClass(B).superclass,
- 'reflect(new A<int>()).type' : reflect(new A<int>()).type},
+ {'reflectClass(B).superclass' : reflectClass(B).superclass, /// 02: ok
+ 'reflect(new A<int>()).type' : reflect(new A<int>()).type}, /// 02: ok
{'reflectClass(B)' : reflectClass(B),
'thisLibrary.classes[#B]' : thisLibrary.classes[const Symbol('B')],
« no previous file with comments | « tests/lib/mirrors/equality_dart2js_test.dart ('k') | tests/lib/mirrors/parameter_dart2js_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698