Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: git_cl.py

Issue 2400793004: Refactor git cl try. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 74a72739bc6c13485a9e2b7a656f745a9fd6c7db..99abda91664ca015470b172e72c7ee2308bbaec0 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -4615,7 +4615,8 @@ def CMDtree(parser, args):
def CMDtry(parser, args):
- '''Triggers try jobs through BuildBucket.'''
+ """Triggers try jobs using CQ dry run or BuildBucket for individual builders.
+ """
group = optparse.OptionGroup(parser, 'Try job options')
group.add_option(
'-b', '--bot', action='append',
@@ -4627,26 +4628,32 @@ def CMDtry(parser, args):
group.add_option(
'-m', '--master', default='',
help=('Specify a try master where to run the tries.'))
+ # TODO(tandrii,nodir): add -B --bucket flag.
group.add_option(
'-r', '--revision',
- help='Revision to use for the try job; default: the '
- 'revision will be determined by the try server; see '
- 'its waterfall for more info')
+ help='Revision to use for the try job; default: the revision will '
+ 'be determined by the try recipe that builder runs, which usually '
+ 'defaults to HEAD of origin/master')
group.add_option(
'-c', '--clobber', action='store_true', default=False,
- help='Force a clobber before building; e.g. don\'t do an '
+ help='Force a clobber before building; that is don\'t do an '
'incremental build')
group.add_option(
'--project',
help='Override which project to use. Projects are defined '
- 'server-side to define what default bot set to use')
+ 'in recipe to determine to which repository or directory to '
+ 'apply the patch')
group.add_option(
'-p', '--property', dest='properties', action='append', default=[],
help='Specify generic properties in the form -p key1=value1 -p '
- 'key2=value2 etc (buildbucket only). The value will be treated as '
- 'json if decodable, or as string otherwise.')
+ 'key2=value2 etc. The value will be treated as '
+ 'json if decodable, or as string otherwise. '
+ 'NOTE: using this may make your try job not usable for CQ, '
+ 'which will then schedule another try job with default properties')
+ # TODO(tandrii): if this even used?
group.add_option(
'-n', '--name', help='Try job name; default to current branch name')
+ # TODO(tandrii): get rid of this.
group.add_option(
'--use-rietveld', action='store_true', default=False,
help='Use Rietveld to trigger try jobs.')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698