Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1643)

Unified Diff: components/ntp_snippets/content_suggestions_service.cc

Issue 2400783003: Ntp: show AllDismissedItem when all sections have been dismissed. (Closed)
Patch Set: Address review comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/content_suggestions_service.cc
diff --git a/components/ntp_snippets/content_suggestions_service.cc b/components/ntp_snippets/content_suggestions_service.cc
index f52a9809d09dcae42dbad4cd9a62ff9598870423..b689990b54198c6ae380ac04e6fbb0b1f707fa39 100644
--- a/components/ntp_snippets/content_suggestions_service.cc
+++ b/components/ntp_snippets/content_suggestions_service.cc
@@ -150,11 +150,19 @@ void ContentSuggestionsService::DismissCategory(Category category) {
if (providers_it == providers_by_category_.end())
return;
+ dismissed_providers_by_category_[providers_it->first] = providers_it->second;
providers_by_category_.erase(providers_it);
categories_.erase(
std::find(categories_.begin(), categories_.end(), category));
}
+void ContentSuggestionsService::RestoreDismissedCategories() {
+ for (const auto& category_provider_pair : dismissed_providers_by_category_)
Marc Treib 2016/10/11 07:35:58 Braces if the body doesn't fit on one line.
Michael van Ouwerkerk 2016/10/11 12:04:16 Done.
+ RegisterCategoryIfRequired(category_provider_pair.second,
+ category_provider_pair.first);
+ dismissed_providers_by_category_.clear();
Marc Treib 2016/10/11 07:35:58 Should RegisterCategoryIfRequired remove the entry
Michael van Ouwerkerk 2016/10/11 12:04:16 Done.
+}
+
void ContentSuggestionsService::AddObserver(Observer* observer) {
observers_.AddObserver(observer);
}

Powered by Google App Engine
This is Rietveld 408576698