Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

Issue 2400783003: Ntp: show AllDismissedItem when all sections have been dismissed. (Closed)
Patch Set: Rebase. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java_sources.gni ('k') | chrome/browser/android/ntp/ntp_snippets_bridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
index a799d4ce8a7426f52f244062d412e0f85779e865..77b1ed21e66819d23e733fe26dac3b7e6c95e2f8 100644
--- a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
@@ -160,10 +160,12 @@ public class NewTabPageAdapterTest {
ItemsMatcher matcher = new ItemsMatcher(mAdapter, 0);
matcher.expect(NewTabPageItem.VIEW_TYPE_ABOVE_THE_FOLD);
for (SectionDescriptor descriptor : descriptors) matcher.expect(descriptor);
- if (descriptors.length > 0) {
+ if (descriptors.length == 0) {
+ matcher.expect(NewTabPageItem.VIEW_TYPE_ALL_DISMISSED);
+ } else {
matcher.expect(NewTabPageItem.VIEW_TYPE_FOOTER);
- matcher.expect(NewTabPageItem.VIEW_TYPE_SPACING);
}
+ matcher.expect(NewTabPageItem.VIEW_TYPE_SPACING);
matcher.expectPosition(mAdapter.getItemCount());
}
@@ -360,7 +362,7 @@ public class NewTabPageAdapterTest {
@Test
@Feature({"Ntp"})
public void testProgressIndicatorDisplay() {
- int progressPos = mAdapter.getLastContentItemPosition() - 1;
+ int progressPos = mAdapter.getFooterPosition() - 1;
SuggestionsSection section = (SuggestionsSection) mAdapter.getGroup(progressPos);
List<NewTabPageItem> items = section.getItems();
ProgressItem progress = (ProgressItem) items.get(items.size() - 1);
« no previous file with comments | « chrome/android/java_sources.gni ('k') | chrome/browser/android/ntp/ntp_snippets_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698