Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: components/ntp_snippets/content_suggestions_service.cc

Issue 2400783003: Ntp: show AllDismissedItem when all sections have been dismissed. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/ntp_snippets/content_suggestions_service.h" 5 #include "components/ntp_snippets/content_suggestions_service.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <iterator> 8 #include <iterator>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 DCHECK(removed) << "The dismissed suggestion " << suggestion_id 143 DCHECK(removed) << "The dismissed suggestion " << suggestion_id
144 << " has already been removed. Providers must not call" 144 << " has already been removed. Providers must not call"
145 << " OnNewSuggestions in response to DismissSuggestion."; 145 << " OnNewSuggestions in response to DismissSuggestion.";
146 } 146 }
147 147
148 void ContentSuggestionsService::DismissCategory(Category category) { 148 void ContentSuggestionsService::DismissCategory(Category category) {
149 auto providers_it = providers_by_category_.find(category); 149 auto providers_it = providers_by_category_.find(category);
150 if (providers_it == providers_by_category_.end()) 150 if (providers_it == providers_by_category_.end())
151 return; 151 return;
152 152
153 dismissed_providers_by_category_[providers_it->first] = providers_it->second;
153 providers_by_category_.erase(providers_it); 154 providers_by_category_.erase(providers_it);
154 categories_.erase( 155 categories_.erase(
155 std::find(categories_.begin(), categories_.end(), category)); 156 std::find(categories_.begin(), categories_.end(), category));
156 } 157 }
157 158
159 void ContentSuggestionsService::RestoreDismissedCategories() {
160 for (const auto& it : dismissed_providers_by_category_)
Marc Treib 2016/10/07 11:40:13 nit: Please give |it| another name, it's not an it
Michael van Ouwerkerk 2016/10/10 16:19:32 Done.
161 RegisterCategoryIfRequired(it.second, it.first);
162 dismissed_providers_by_category_.clear();
163 }
164
158 void ContentSuggestionsService::AddObserver(Observer* observer) { 165 void ContentSuggestionsService::AddObserver(Observer* observer) {
159 observers_.AddObserver(observer); 166 observers_.AddObserver(observer);
160 } 167 }
161 168
162 void ContentSuggestionsService::RemoveObserver(Observer* observer) { 169 void ContentSuggestionsService::RemoveObserver(Observer* observer) {
163 observers_.RemoveObserver(observer); 170 observers_.RemoveObserver(observer);
164 } 171 }
165 172
166 void ContentSuggestionsService::RegisterProvider( 173 void ContentSuggestionsService::RegisterProvider(
167 std::unique_ptr<ContentSuggestionsProvider> provider) { 174 std::unique_ptr<ContentSuggestionsProvider> provider) {
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 if (left.IsKnownCategory(KnownCategories::BOOKMARKS)) 332 if (left.IsKnownCategory(KnownCategories::BOOKMARKS))
326 return false; 333 return false;
327 if (right.IsKnownCategory(KnownCategories::BOOKMARKS)) 334 if (right.IsKnownCategory(KnownCategories::BOOKMARKS))
328 return true; 335 return true;
329 } 336 }
330 return category_factory_.CompareCategories(left, right); 337 return category_factory_.CompareCategories(left, right);
331 }); 338 });
332 } 339 }
333 340
334 } // namespace ntp_snippets 341 } // namespace ntp_snippets
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698