Slightly simplify CFX_FontMapper::FindSubstFont

Slightly simplify CFX_FontMapper::FindSubstFont

- Deleted useless flag FXFONT_SUBST_STANDARD
- Change kExternalFontIndex to something more meaningful
- Fetch symbolic fonts using UseInternalSubst too

Committed: https://pdfium.googlesource.com/pdfium/+/232ce9365df0768846972be34a3a84f915bf7e82

[npm, 2016-10-06 19:33:47]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 19:33:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-10-06 19:43:23]

Description was changed from

==========
Slightly simplify CFX_FontMapper::FindSubstFont
==========

to

==========
Slightly simplify CFX_FontMapper::FindSubstFont

- Deleted useless flag FXFONT_SUBST_STANDARD
- Change kExternalFontIndex to something more meaningful
- Fetch symbolic fonts using UseInternalSubst too
==========

[npm, 2016-10-06 19:43:24]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org, weili@chromium.org

[npm, 2016-10-06 19:43:39]

PTAL

[commit-bot: I haz the power, 2016-10-06 19:46:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 19:46:47]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-10-11 14:11:37]

https://codereview.chromium.org/2400773002/diff/1/core/fxge/ge/cfx_fontmapper...
File core/fxge/ge/cfx_fontmapper.cpp (right):

https://codereview.chromium.org/2400773002/diff/1/core/fxge/ge/cfx_fontmapper...
core/fxge/ge/cfx_fontmapper.cpp:390: if (iBaseFont < kNumStandardFonts) {
Doesn't this change the meaning? Previously it was if < 12, now it's if < 14.

Are Symbol and ZapfDingbats considered external fonts?

[npm, 2016-10-11 14:19:56]

https://codereview.chromium.org/2400773002/diff/1/core/fxge/ge/cfx_fontmapper...
File core/fxge/ge/cfx_fontmapper.cpp (right):

https://codereview.chromium.org/2400773002/diff/1/core/fxge/ge/cfx_fontmapper...
core/fxge/ge/cfx_fontmapper.cpp:390: if (iBaseFont < kNumStandardFonts) {
On 2016/10/11 14:11:37, dsinclair wrote:
> Doesn't this change the meaning? Previously it was if < 12, now it's if < 14.
> 
> Are Symbol and ZapfDingbats considered external fonts?

That is precisely what I want because I now use it for Symbol (12) and
ZapfDingbats (13). I disagree with the previous naming. Those two fonts are the
two symbolic standard fonts. The other 12 fonts are the nonsymbolic standard
fonts.

[dsinclair, 2016-10-11 15:39:58]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-10-11 15:39:59]

lgtm

[commit-bot: I haz the power, 2016-10-11 15:40:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 15:57:03]

Description was changed from

==========
Slightly simplify CFX_FontMapper::FindSubstFont

- Deleted useless flag FXFONT_SUBST_STANDARD
- Change kExternalFontIndex to something more meaningful
- Fetch symbolic fonts using UseInternalSubst too
==========

to

==========
Slightly simplify CFX_FontMapper::FindSubstFont

- Deleted useless flag FXFONT_SUBST_STANDARD
- Change kExternalFontIndex to something more meaningful
- Fetch symbolic fonts using UseInternalSubst too

Committed:
https://pdfium.googlesource.com/pdfium/+/232ce9365df0768846972be34a3a84f915bf...
==========

[commit-bot: I haz the power, 2016-10-11 15:57:04]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/232ce9365df0768846972be34a3a84f915bf...