Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2400733002: cc: Restructure access to LayerTreeHost in LayerTreeTests. (Closed)

Created:
4 years, 2 months ago by Khushal
Modified:
4 years, 2 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Restructure access to LayerTreeHost in LayerTreeTests. Move tests to depends on the LayerTreeHost, instead of the InProcess subclass, in preparation of setting up the framework to have tests run in remote mode. There is still an accessor for LayerTreeHostInProcess, only it DCHECKS that the test is running in threaded or single-threaded mode. BUG=653371 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/20d374bbeeefaf135d66038d43ceacbfaef9c9e4 Cr-Commit-Position: refs/heads/master@{#423727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -16 lines) Patch
M cc/test/layer_tree_test.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/layer_tree_test.cc View 1 chunk +7 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
Khushal
4 years, 2 months ago (2016-10-06 18:05:09 UTC) #3
vmpstr
lgtm
4 years, 2 months ago (2016-10-06 22:30:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400733002/1
4 years, 2 months ago (2016-10-06 22:34:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 23:20:40 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 23:22:11 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20d374bbeeefaf135d66038d43ceacbfaef9c9e4
Cr-Commit-Position: refs/heads/master@{#423727}

Powered by Google App Engine
This is Rietveld 408576698