Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2400693002: Make apk_merger.py use hermetic timestamps. (Closed)

Created:
4 years, 2 months ago by agrieve
Modified:
4 years, 2 months ago
Reviewers:
michaelbai
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make apk_merger.py use hermetic timestamps. This ensures two runs of the merger with same inputs results in the same outputs. Committed: https://crrev.com/96f11a3f422215131a9823e95a9f4d5777c538c9 Cr-Commit-Position: refs/heads/master@{#423627}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add var #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -47 lines) Patch
M android_webview/tools/apk_merger.py View 3 chunks +21 lines, -45 lines 0 comments Download
M build/android/gyp/util/build_utils.py View 1 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
agrieve
4 years, 2 months ago (2016-10-06 15:12:53 UTC) #2
michaelbai
lgtm https://codereview.chromium.org/2400693002/diff/1/build/android/gyp/util/build_utils.py File build/android/gyp/util/build_utils.py (right): https://codereview.chromium.org/2400693002/diff/1/build/android/gyp/util/build_utils.py#newcode352 build/android/gyp/util/build_utils.py:352: if isinstance(output, basestring): nit, use variable instead of ...
4 years, 2 months ago (2016-10-06 18:05:41 UTC) #4
agrieve
https://codereview.chromium.org/2400693002/diff/1/build/android/gyp/util/build_utils.py File build/android/gyp/util/build_utils.py (right): https://codereview.chromium.org/2400693002/diff/1/build/android/gyp/util/build_utils.py#newcode352 build/android/gyp/util/build_utils.py:352: if isinstance(output, basestring): On 2016/10/06 18:05:41, michaelbai wrote: > ...
4 years, 2 months ago (2016-10-06 18:17:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400693002/20001
4 years, 2 months ago (2016-10-06 18:17:52 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 19:29:18 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 19:32:19 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/96f11a3f422215131a9823e95a9f4d5777c538c9
Cr-Commit-Position: refs/heads/master@{#423627}

Powered by Google App Engine
This is Rietveld 408576698