chrome/browser/ssl/bad_clock_blocking_page.cc - Issue 2400673003: Remove SSLStatus::security_style member and content::SecurityStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/bad_clock_blocking_page.cc

Issue 2400673003: Remove SSLStatus::security_style member and content::SecurityStyle (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ssl/bad_clock_blocking_page.cc

diff --git a/chrome/browser/ssl/bad_clock_blocking_page.cc b/chrome/browser/ssl/bad_clock_blocking_page.cc

index 1ee6156f4a3198cbe7f23c47a40154a205fdfb19..fa245221ce32d004b89253aef836e3cd3d4deb67 100644

--- a/chrome/browser/ssl/bad_clock_blocking_page.cc

+++ b/chrome/browser/ssl/bad_clock_blocking_page.cc

@@ -106,8 +106,7 @@ void BadClockBlockingPage::PopulateInterstitialStrings(

}

void BadClockBlockingPage::OverrideEntry(NavigationEntry* entry) {

- entry->GetSSL() = content::SSLStatus(

- content::SECURITY_STYLE_AUTHENTICATION_BROKEN, ssl_info_.cert, ssl_info_);

+ entry->GetSSL() = content::SSLStatus(ssl_info_.cert, ssl_info_);

felt 2016/10/07 03:30:48 Does the omnibox still get correctly downgraded fo

estark 2016/10/07 06:34:31 Tested manually, they look right except for crbug.

}

void BadClockBlockingPage::SetSSLCertReporterForTesting(