Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2400633002: [turbofan] Pass NoContextConstant to stubs that don't need a context. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Pass NoContextConstant to stubs that don't need a context. The generic implementations for typeof, strict equality and ToBoolean don't need a context, so we can just pass the NoContextConstant (which is Smi zero) instead, to reduce the live ranges for the context. R=mvstanton@chromium.org Committed: https://crrev.com/1411c7628b6c2eb325585fabcbfe7c4164de8640 Cr-Commit-Position: refs/heads/master@{#40027}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/compiler/js-generic-lowering.cc View 4 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-06 09:19:19 UTC) #1
mvstanton
lgtm
4 years, 2 months ago (2016-10-06 09:25:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400633002/1
4 years, 2 months ago (2016-10-06 10:12:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 10:15:29 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 10:15:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1411c7628b6c2eb325585fabcbfe7c4164de8640
Cr-Commit-Position: refs/heads/master@{#40027}

Powered by Google App Engine
This is Rietveld 408576698