Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 240063003: Revert "A sizes attribute parser" (https://codereview.chromium.org/224733011) (Closed)

Created:
6 years, 8 months ago by hayato
Modified:
6 years, 8 months ago
Reviewers:
Yoav Weiss, eseidel
CC:
blink-reviews, kenneth.christiansen, Yoav Weiss, arv+blink, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, rune+blink, watchdog-blink-watchlist_google.com, Inactive, rwlbuis
Visibility:
Public.

Description

Revert "A sizes attribute parser" (https://codereview.chromium.org/224733011) Reason for revert: [blink gardening] SystemMemoryApiTest.Memory started to fail. http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/35970 I manually bisected in range 171674: 171705. After r171701, SystemMemoryApiTest.Memory started to fail. I suspect this patch might be also the cause of the failures of other tests, such as Storage, StorageAttachment and so on. Let me revert this. TBR=yoav@yoav.ws,eseidel@chromium.org NOTREECHECKS=true NOTRY=true BUG=357586 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171751

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+380 lines, -926 lines) Patch
D LayoutTests/fast/dom/HTMLImageElement/image-sizes-invalid-length.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/dom/HTMLImageElement/image-sizes-invalid-length-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/dom/HTMLImageElement/image-sizes-simple.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/dom/HTMLImageElement/image-sizes-simple-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/core.gypi View 3 chunks +0 lines, -4 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/MediaQueryEvaluator.cpp View 9 chunks +45 lines, -11 lines 0 comments Download
M Source/core/css/MediaQueryEvaluatorTest.cpp View 3 chunks +17 lines, -23 lines 0 comments Download
M Source/core/css/MediaQueryExp.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/MediaQuerySetTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/MediaValues.h View 1 chunk +83 lines, -54 lines 0 comments Download
M Source/core/css/MediaValues.cpp View 8 chunks +223 lines, -44 lines 0 comments Download
D Source/core/css/MediaValuesCached.h View 1 chunk +0 lines, -68 lines 0 comments Download
D Source/core/css/MediaValuesCached.cpp View 1 chunk +0 lines, -211 lines 0 comments Download
D Source/core/css/MediaValuesDynamic.h View 1 chunk +0 lines, -47 lines 0 comments Download
D Source/core/css/MediaValuesDynamic.cpp View 1 chunk +0 lines, -144 lines 0 comments Download
M Source/core/css/parser/MediaConditionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/MediaQueryParser.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/css/parser/MediaQueryParser.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
D Source/core/css/parser/SizesAttributeParser.h View 1 chunk +0 lines, -40 lines 0 comments Download
D Source/core/css/parser/SizesAttributeParser.cpp View 1 chunk +0 lines, -134 lines 0 comments Download
D Source/core/css/parser/SizesAttributeParserTest.cpp View 1 chunk +0 lines, -80 lines 0 comments Download
M Source/core/html/HTMLImageElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 3 chunks +0 lines, -5 lines 0 comments Download
M Source/core/html/HTMLImageElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.cpp View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hayato
The CQ bit was checked by hayato@chromium.org
6 years, 8 months ago (2014-04-16 06:49:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/240063003/1
6 years, 8 months ago (2014-04-16 06:49:17 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 06:49:50 UTC) #3
Message was sent while issue was closed. 
Change committed as 171751

Powered by Google App Engine
This is Rietveld 408576698