Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 240063002: [webcrypto] Update layout tests to match idl generator changes. (Closed)

Created:
6 years, 8 months ago by eroman
Modified:
6 years, 8 months ago
Reviewers:
yhirano
CC:
blink-reviews
Visibility:
Public.

Description

[webcrypto] Update layout tests to match idl generator changes. Functions that return Promises no longer throw TypeError exceptions. BUG=362992, 245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171789

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -18 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/crypto/aes-cbc-generateKey-parseAlgorithm-failures.html View 1 chunk +12 lines, -4 lines 0 comments Download
M LayoutTests/crypto/aes-cbc-generateKey-parseAlgorithm-failures-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/crypto/digest-failures.html View 1 chunk +6 lines, -3 lines 0 comments Download
M LayoutTests/crypto/digest-failures-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/crypto/resources/common.js View 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/crypto/unwrapKey-badParameters.html View 2 chunks +8 lines, -2 lines 0 comments Download
M LayoutTests/crypto/unwrapKey-badParameters-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
eroman
6 years, 8 months ago (2014-04-16 05:59:04 UTC) #1
yhirano
lgtm. Thank you for doing this.
6 years, 8 months ago (2014-04-16 09:10:41 UTC) #2
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 8 months ago (2014-04-16 17:35:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/240063002/1
6 years, 8 months ago (2014-04-16 17:36:17 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 18:01:53 UTC) #5
Message was sent while issue was closed.
Change committed as 171789

Powered by Google App Engine
This is Rietveld 408576698