Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 24006: Work around a Purify bug by making an object used by NetTestSuite stack alloc... (Closed)

Created:
11 years, 10 months ago by Erik does not do reviews
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Work around a Purify bug by moving initialization from constructor to Inititialize(). BUG=7467 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9354

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M net/base/host_resolver_unittest.h View 1 chunk +8 lines, -0 lines 0 comments Download
M net/base/run_all_unittests.cc View 1 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Erik does not do reviews
11 years, 10 months ago (2009-02-06 21:55:44 UTC) #1
Paweł Hajdan Jr.
LGTM
11 years, 10 months ago (2009-02-06 21:58:06 UTC) #2
Erik does not do reviews
OK. Please take a fresh look. This appears to fix the problem, and is less ...
11 years, 10 months ago (2009-02-06 22:51:21 UTC) #3
darin (slow to review)
11 years, 10 months ago (2009-02-06 22:53:58 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698