Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2400573002: Fix chromium_perf_fyi android FYI builder compile targets (Closed)

Created:
4 years, 2 months ago by martiniss
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Fix chromium_perf_fyi android FYI builder compile targets This should be done in a more automated way, but for now do this to unblock seeing if android can switch to the chromium recipe. BUG=639530 Committed: https://chromium.googlesource.com/chromium/tools/build/+/c36aaf1c36deaa69fb914ad68388da7b2ea5e2a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_perf.py View 2 chunks +4 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py View 2 chunks +12 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Android_Builder_FYI.json View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
martiniss
PTAL temporary; need to change DynamicPerfTest to actually have this info. Copied from https://cs.chromium.org/chromium/build/scripts/slave/recipes/android/builder.py?q=android/builder.py&sq=package:chromium&l=65
4 years, 2 months ago (2016-10-06 01:54:50 UTC) #2
jbudorick
lgtm
4 years, 2 months ago (2016-10-06 01:58:13 UTC) #5
dtu
lgtm
4 years, 2 months ago (2016-10-06 06:33:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400573002/1
4 years, 2 months ago (2016-10-06 06:33:32 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 06:37:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/c36aaf1c36deaa69fb91...

Powered by Google App Engine
This is Rietveld 408576698