Adjust shadow and stroke of MdTextButton.

Adjust shadow and stroke of MdTextButton.

Also fix the appearance of the "Show All" button on the download shelf when using custom themes (this regressed at some point in M55, as it works properly in my M54 build).

BUG=647047
Committed: https://crrev.com/b440caef76273a30858144990c14bc4fa9793525
Cr-Commit-Position: refs/heads/master@{#423689}

[Evan Stade, 2016-10-06 01:34:38]

Description was changed from

==========
Adjust shadow and stroke of MdTextButton.

BUG=647047
==========

to

==========
Adjust shadow and stroke of MdTextButton.

Also fix the appearance of the "Show All" button on the download shelf when
using custom themes (this regressed at some point in M55, as it works properly
in my M54 build).

BUG=647047
==========

[Evan Stade, 2016-10-06 01:34:38]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2016-10-06 01:34:43]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 01:35:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 03:15:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 03:15:15]

Dry run: This issue passed the CQ dry run.

[sky, 2016-10-06 17:09:45]

https://codereview.chromium.org/2400563004/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/download/download_shelf_view.cc (right):

https://codereview.chromium.org/2400563004/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/download/download_shelf_view.cc:329:
show_all_view_->SchedulePaint();
In general I would expect changing properties on views to trigger the necessary
painting for you. In this case that means SetBgColorOverriding should be the one
doing that. I think View::set_background() should as well.

https://codereview.chromium.org/2400563004/diff/20001/ui/views/animation/ink_...
File ui/views/animation/ink_drop_painted_layer_delegates.h (right):

https://codereview.chromium.org/2400563004/diff/20001/ui/views/animation/ink_...
ui/views/animation/ink_drop_painted_layer_delegates.h:139: SkColor fill_color_;
const if you can.

[Evan Stade, 2016-10-06 17:43:38]

https://codereview.chromium.org/2400563004/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/download/download_shelf_view.cc (right):

https://codereview.chromium.org/2400563004/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/download/download_shelf_view.cc:329:
show_all_view_->SchedulePaint();
On 2016/10/06 17:09:45, sky wrote:
> In general I would expect changing properties on views to trigger the
necessary
> painting for you. In this case that means SetBgColorOverriding should be the
one
> doing that. I think View::set_background() should as well.

this was leftover from a previous iteration of the code (before I changed
set_bg_color_override to SetBgColorOverride). Removed.

https://codereview.chromium.org/2400563004/diff/20001/ui/views/animation/ink_...
File ui/views/animation/ink_drop_painted_layer_delegates.h (right):

https://codereview.chromium.org/2400563004/diff/20001/ui/views/animation/ink_...
ui/views/animation/ink_drop_painted_layer_delegates.h:139: SkColor fill_color_;
On 2016/10/06 17:09:45, sky wrote:
> const if you can.

added to all the members

[Evan Stade, 2016-10-06 17:43:44]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 17:44:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 18:25:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 18:25:49]

Dry run: This issue passed the CQ dry run.

[sky, 2016-10-06 21:20:12]

LGTM

[Evan Stade, 2016-10-06 21:26:30]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-10-06 21:27:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 21:33:43]

Description was changed from

==========
Adjust shadow and stroke of MdTextButton.

Also fix the appearance of the "Show All" button on the download shelf when
using custom themes (this regressed at some point in M55, as it works properly
in my M54 build).

BUG=647047
==========

to

==========
Adjust shadow and stroke of MdTextButton.

Also fix the appearance of the "Show All" button on the download shelf when
using custom themes (this regressed at some point in M55, as it works properly
in my M54 build).

BUG=647047
==========

[commit-bot: I haz the power, 2016-10-06 21:33:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-06 21:35:51]

Description was changed from

==========
Adjust shadow and stroke of MdTextButton.

Also fix the appearance of the "Show All" button on the download shelf when
using custom themes (this regressed at some point in M55, as it works properly
in my M54 build).

BUG=647047
==========

to

==========
Adjust shadow and stroke of MdTextButton.

Also fix the appearance of the "Show All" button on the download shelf when
using custom themes (this regressed at some point in M55, as it works properly
in my M54 build).

BUG=647047

Committed: https://crrev.com/b440caef76273a30858144990c14bc4fa9793525
Cr-Commit-Position: refs/heads/master@{#423689}
==========

[commit-bot: I haz the power, 2016-10-06 21:35:52]

Patchset 3 (id:??) landed as
https://crrev.com/b440caef76273a30858144990c14bc4fa9793525
Cr-Commit-Position: refs/heads/master@{#423689}