Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: third_party/WebKit/Source/core/mojo/MojoWatcher.cpp

Issue 2400563002: Adds Mojo IDL. (Closed)
Patch Set: addressed comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/mojo/MojoWatcher.cpp
diff --git a/third_party/WebKit/Source/core/mojo/MojoWatcher.cpp b/third_party/WebKit/Source/core/mojo/MojoWatcher.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..412ce4058c6ea4c950f58412ea5b501505b1cec3
--- /dev/null
+++ b/third_party/WebKit/Source/core/mojo/MojoWatcher.cpp
@@ -0,0 +1,82 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/mojo/MojoWatcher.h"
+
+#include "bindings/core/v8/MojoWatchCallback.h"
+#include "bindings/core/v8/ScriptState.h"
+#include "core/dom/ExecutionContext.h"
+#include "core/dom/ExecutionContextTask.h"
+
+namespace blink {
+
+MojoWatcher* MojoWatcher::create(mojo::Handle handle,
+ MojoHandleSignals signals,
+ MojoWatchCallback* callback,
+ ExecutionContext* taskRunner) {
+ MojoWatcher* watcher = new MojoWatcher(handle, callback, taskRunner);
+
+ MojoResult result =
+ MojoWatch(handle.value(), signals, &MojoWatcher::onHandleReady,
+ reinterpret_cast<uintptr_t>(watcher));
+ // TODO(alokp): Consider raising an exception.
+ // Current clients expect to recieve the initial error returned by MojoWatch
+ // via watch callback.
+ if (result != MOJO_RESULT_OK) {
+ watcher->m_taskRunner->postTask(
+ BLINK_FROM_HERE,
+ createSameThreadTask(&MojoWatcher::runReadyCallback,
+ wrapWeakPersistent(watcher), result));
+ }
+ return watcher;
+}
+
+MojoWatcher::MojoWatcher(mojo::Handle handle,
+ MojoWatchCallback* callback,
+ ExecutionContext* taskRunner)
+ : m_handle(handle), m_callback(this, callback), m_taskRunner(taskRunner) {}
+
+MojoWatcher::~MojoWatcher() {
+ cancel();
jbroman 2017/01/10 20:46:31 Hold on, what stops this from being cancelled the
alokp 2017/01/11 21:53:02 Done.
+}
+
+MojoResult MojoWatcher::cancel() {
+ MojoResult result = MOJO_RESULT_OK;
+ if (m_handle.is_valid()) {
+ result =
+ MojoCancelWatch(m_handle.value(), reinterpret_cast<uintptr_t>(this));
+ m_handle = mojo::Handle();
+ }
+ return result;
+}
+
+DEFINE_TRACE_WRAPPERS(MojoWatcher) {
+ visitor->traceWrappers(m_callback);
+}
+
+void MojoWatcher::onHandleReady(uintptr_t context,
+ MojoResult result,
+ MojoHandleSignalsState,
jbroman 2017/01/10 20:46:31 Does script not need to know which signals are rea
alokp 2017/01/11 21:53:02 C API currently does not specify the signals for w
yzshen1 2017/01/12 23:38:34 I don't think it is super useful. I am fine not ha
+ MojoWatchNotificationFlags) {
+ // It is safe to assume the MojoWatcher still exists because this
+ // callback will never be run after MojoWatcher destructor,
+ // which cancels the watch.
+ MojoWatcher* watcher = reinterpret_cast<MojoWatcher*>(context);
+ watcher->m_taskRunner->postTask(
+ BLINK_FROM_HERE,
+ createCrossThreadTask(&MojoWatcher::runReadyCallback,
+ wrapCrossThreadWeakPersistent(watcher), result));
+}
+
+void MojoWatcher::runReadyCallback(MojoResult result) {
+ if (!m_handle.is_valid())
+ return;
+
+ if (result != MOJO_RESULT_OK)
+ cancel();
+
+ m_callback->call(this, result);
+}
+
+} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698