ash: Remove broken display notification suppression when settings is open

ash/system/chromeos/screen_layout_observer.h

Index: ash/system/chromeos/screen_layout_observer.h
diff --git a/ash/system/chromeos/screen_layout_observer.h b/ash/system/chromeos/screen_layout_observer.h
index 59409c66190944c9da3d7bc1c8d5c8440dfd5b26..a97996837f147b44bcc18633b9ca16847fe603a1 100644
--- a/ash/system/chromeos/screen_layout_observer.h
+++ b/ash/system/chromeos/screen_layout_observer.h
@@ -29,6 +29,11 @@ class ASH_EXPORT ScreenLayoutObserver : public WmDisplayObserver {
   // Overridden from WmDisplayObserver:
   void OnDisplayConfigurationChanged() override;
 
+  // Allow tests to suppress showing notifications.

[oshima, 2016/10/11 20:50:34]

nit: update the comment. (or clarify as it sounds confusing)
it's probably better to say the default is true (allowed) but false in unit
tests.

[James Cook, 2016/10/11 20:58:17]

Done.

+  void set_show_notifications_for_testing(bool show) {
+    show_notifications_for_testing = show;
+  }
+
  private:
   friend class ScreenLayoutObserverTest;
 
@@ -56,6 +61,8 @@ class ASH_EXPORT ScreenLayoutObserver : public WmDisplayObserver {
 
   DisplayInfoMap display_info_;
 
+  bool show_notifications_for_testing = true;
+
   DISALLOW_COPY_AND_ASSIGN(ScreenLayoutObserver);
 };