[Cast, Tests] Handle low end and JB devices that don't preload videos

[Cast, Tests] Handle low end and JB devices that don't preload videos

BUG=652872, 652389
TEST=run_chrome_public_test_apk --verbose --gtest_filter=org.chromium.chrome.browser.media.remote.* on both low end and not a low end device.

Since https://codereview.chromium.org/2344353003 on low-end and JB devices videos
are not preloaded so we have to trigger that in a button onclick handler.

Committed: https://crrev.com/6e5b06e0201d483a1596aedf438fb931fbbe7b42
Cr-Commit-Position: refs/heads/master@{#423775}

[whywhat, 2016-10-05 23:30:08]

avayvod@chromium.org changed reviewers:
+ mlamouri@chromium.org

[whywhat, 2016-10-05 23:30:09]

PTaL

[whywhat, 2016-10-05 23:30:14]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 23:30:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 02:55:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 02:55:52]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mlamouri (slow - plz ping), 2016-10-06 11:07:23]

lgtm

[Tobias Sargeant, 2016-10-06 14:03:18]

On 2016/10/06 11:07:23, mlamouri wrote:
> lgtm

Also BUG=652389, given that that now mentions other broken low-end tests.

[whywhat, 2016-10-06 17:29:13]

Description was changed from

==========
[Cast, Tests] Handle low end and JB devices that don't preload videos

BUG=652872
TEST=run_chrome_public_test_apk --verbose
--gtest_filter=org.chromium.chrome.browser.media.remote.* on both low end and
not a low end device.

Since https://codereview.chromium.org/2344353003 on low-end and JB devices
videos
are not preloaded so we have to trigger that in a button onclick handler.
==========

to

==========
[Cast, Tests] Handle low end and JB devices that don't preload videos

BUG=652872,652389
TEST=run_chrome_public_test_apk --verbose
--gtest_filter=org.chromium.chrome.browser.media.remote.* on both low end and
not a low end device.

Since https://codereview.chromium.org/2344353003 on low-end and JB devices
videos
are not preloaded so we have to trigger that in a button onclick handler.
==========

[whywhat, 2016-10-06 17:31:48]

The CQ bit was checked by avayvod@chromium.org

[commit-bot: I haz the power, 2016-10-06 17:32:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 19:35:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 19:35:59]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[whywhat, 2016-10-06 22:05:50]

The CQ bit was checked by avayvod@chromium.org

[commit-bot: I haz the power, 2016-10-06 22:06:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 01:34:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-07 01:36:55]

Description was changed from

==========
[Cast, Tests] Handle low end and JB devices that don't preload videos

BUG=652872,652389
TEST=run_chrome_public_test_apk --verbose
--gtest_filter=org.chromium.chrome.browser.media.remote.* on both low end and
not a low end device.

Since https://codereview.chromium.org/2344353003 on low-end and JB devices
videos
are not preloaded so we have to trigger that in a button onclick handler.
==========

to

==========
[Cast, Tests] Handle low end and JB devices that don't preload videos

BUG=652872,652389
TEST=run_chrome_public_test_apk --verbose
--gtest_filter=org.chromium.chrome.browser.media.remote.* on both low end and
not a low end device.

Since https://codereview.chromium.org/2344353003 on low-end and JB devices
videos
are not preloaded so we have to trigger that in a button onclick handler.

Committed: https://crrev.com/6e5b06e0201d483a1596aedf438fb931fbbe7b42
Cr-Commit-Position: refs/heads/master@{#423775}
==========

[commit-bot: I haz the power, 2016-10-07 01:36:57]

Patchset 1 (id:??) landed as
https://crrev.com/6e5b06e0201d483a1596aedf438fb931fbbe7b42
Cr-Commit-Position: refs/heads/master@{#423775}

[Ken Rockot(use gerrit already), 2016-10-07 05:21:44]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2394273003/ by rockot@chromium.org.

The reason for reverting is: Speculative revert because cast tests started
flaking very heavily at this revision and it's effectively blocking things in
the CQ.

See
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...
for example failures.

[Ken Rockot(use gerrit already), 2016-10-07 06:07:56]

On 2016/10/07 at 05:21:44, Ken Rockot wrote:
> A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2394273003/ by rockot@chromium.org.
> 
> The reason for reverting is: Speculative revert because cast tests started
flaking very heavily at this revision and it's effectively blocking things in
the CQ.
> 
> See
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...
for example failures.

Just to follow up, it looks like the revert fixed the flake issue. Here's a link
to a failing run before the revert:
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...
- not much to go on AFAICT except timeouts on these tests:

CastNotificationTest_testNotificationPause
CastPositionTransferTest_testPositionUpdate
CastPositionTransferTest_testRemoteToLocalPositionTransfer
CastVideoControlsTest_testPauseButton

[boliu, 2016-10-07 18:41:33]

fwiw, these tests failed many times on the try runs of this CL. I guess there's
a default assumption that things are flaky, so author didn't even check the
failures, and just rechecked cq until it went through :(