src/mips/code-stubs-mips.cc - Issue 240053010: Return Object* instead of MaybeObject* from runtime calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/code-stubs-mips.cc

Issue 240053010: Return Object* instead of MaybeObject* from runtime calls. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: arm64 port Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Index: src/mips/code-stubs-mips.cc

diff --git a/src/mips/code-stubs-mips.cc b/src/mips/code-stubs-mips.cc

index 31851a230051a2b09b099b28745f53a756d3de8d..57f75bb968ed5656091eb4213a10009bcedf4d29 100644

--- a/src/mips/code-stubs-mips.cc

+++ b/src/mips/code-stubs-mips.cc

@@ -1899,7 +1899,7 @@ void JSEntryStub::GenerateBody(MacroAssembler* masm, bool is_construct) {

__ li(t0, Operand(ExternalReference(Isolate::kPendingExceptionAddress,

isolate)));

__ sw(v0, MemOperand(t0)); // We come back from 'invoke'. result is in v0.

- __ li(v0, Operand(reinterpret_cast<int32_t>(Failure::Exception())));

+ __ LoadRoot(v0, Heap::kExceptionRootIndex);

__ b(&exit); // b exposes branch delay slot.

__ nop(); // Branch delay slot nop.

« src/ia32/code-stubs-ia32.cc ('K') | « src/isolate.cc ('k') | src/mips/regexp-macro-assembler-mips.cc » ('j') | src/x64/code-stubs-x64.cc » ('J')