Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: src/mips/regexp-macro-assembler-mips.cc

Issue 240053010: Return Object* instead of MaybeObject* from runtime calls. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: cmpp Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | src/runtime.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1135 matching lines...) Expand 10 before | Expand all | Expand 10 after
1146 Handle<Code> code_handle(re_code); 1146 Handle<Code> code_handle(re_code);
1147 1147
1148 Handle<String> subject(frame_entry<String*>(re_frame, kInputString)); 1148 Handle<String> subject(frame_entry<String*>(re_frame, kInputString));
1149 // Current string. 1149 // Current string.
1150 bool is_ascii = subject->IsOneByteRepresentationUnderneath(); 1150 bool is_ascii = subject->IsOneByteRepresentationUnderneath();
1151 1151
1152 ASSERT(re_code->instruction_start() <= *return_address); 1152 ASSERT(re_code->instruction_start() <= *return_address);
1153 ASSERT(*return_address <= 1153 ASSERT(*return_address <=
1154 re_code->instruction_start() + re_code->instruction_size()); 1154 re_code->instruction_start() + re_code->instruction_size());
1155 1155
1156 MaybeObject* result = Execution::HandleStackGuardInterrupt(isolate); 1156 Object* result = Execution::HandleStackGuardInterrupt(isolate);
1157 1157
1158 if (*code_handle != re_code) { // Return address no longer valid. 1158 if (*code_handle != re_code) { // Return address no longer valid.
1159 int delta = code_handle->address() - re_code->address(); 1159 int delta = code_handle->address() - re_code->address();
1160 // Overwrite the return address on the stack. 1160 // Overwrite the return address on the stack.
1161 *return_address += delta; 1161 *return_address += delta;
1162 } 1162 }
1163 1163
1164 if (result->IsException()) { 1164 if (result->IsException()) {
1165 return EXCEPTION; 1165 return EXCEPTION;
1166 } 1166 }
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
1338 } 1338 }
1339 1339
1340 1340
1341 #undef __ 1341 #undef __
1342 1342
1343 #endif // V8_INTERPRETED_REGEXP 1343 #endif // V8_INTERPRETED_REGEXP
1344 1344
1345 }} // namespace v8::internal 1345 }} // namespace v8::internal
1346 1346
1347 #endif // V8_TARGET_ARCH_MIPS 1347 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | src/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698