Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: src/debug.cc

Issue 240053010: Return Object* instead of MaybeObject* from runtime calls. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: cmpp Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/debug.h ('k') | src/execution.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1043 matching lines...) Expand 10 before | Expand all | Expand 10 after
1054 Builtins::kFrameDropper_LiveEdit); 1054 Builtins::kFrameDropper_LiveEdit);
1055 thread_local_.after_break_target_ = plain_return->entry(); 1055 thread_local_.after_break_target_ = plain_return->entry();
1056 } else { 1056 } else {
1057 UNREACHABLE(); 1057 UNREACHABLE();
1058 } 1058 }
1059 1059
1060 return heap->undefined_value(); 1060 return heap->undefined_value();
1061 } 1061 }
1062 1062
1063 1063
1064 RUNTIME_FUNCTION(Object*, Debug_Break) { 1064 RUNTIME_FUNCTION(Debug_Break) {
1065 return isolate->debug()->Break(args); 1065 return isolate->debug()->Break(args);
1066 } 1066 }
1067 1067
1068 1068
1069 // Check the break point objects for whether one or more are actually 1069 // Check the break point objects for whether one or more are actually
1070 // triggered. This function returns a JSArray with the break point objects 1070 // triggered. This function returns a JSArray with the break point objects
1071 // which is triggered. 1071 // which is triggered.
1072 Handle<Object> Debug::CheckBreakPoints(Handle<Object> break_point_objects) { 1072 Handle<Object> Debug::CheckBreakPoints(Handle<Object> break_point_objects) {
1073 Factory* factory = isolate_->factory(); 1073 Factory* factory = isolate_->factory();
1074 1074
(...skipping 2660 matching lines...) Expand 10 before | Expand all | Expand 10 after
3735 { 3735 {
3736 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_)); 3736 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_));
3737 isolate_->debugger()->CallMessageDispatchHandler(); 3737 isolate_->debugger()->CallMessageDispatchHandler();
3738 } 3738 }
3739 } 3739 }
3740 } 3740 }
3741 3741
3742 #endif // ENABLE_DEBUGGER_SUPPORT 3742 #endif // ENABLE_DEBUGGER_SUPPORT
3743 3743
3744 } } // namespace v8::internal 3744 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/debug.h ('k') | src/execution.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698