Issue 240053005: Various minor improvements to recipe_simulation_test.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 240053005: Various minor improvements to recipe_simulation_test.py. (Closed)

Created:
6 years, 8 months ago by Vadim Sh.

Modified:
6 years, 8 months ago

Reviewers:
iannucci

CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build

Visibility:
Public.

More Reviews

Description

Various minor improvements to recipe_simulation_test.py. * Implicitly append '*' to the test glob. That way 'recipe_simluation_test train <recipe_name>' will actually discover required tests (named <recipe_name>.<test_name>) which is expected behavior. * Print a message and fail the run if given test glob doesn't match any tests. * Do not break in mods.step.API.__call__ when running in debug mode. It's very confusing. Still break at GenSteps though. R=iannucci@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=264370

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -7 lines)			Patch
M	scripts/slave/unittests/expect_tests/main.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	scripts/slave/unittests/expect_tests/pipeline.py	View	3 chunks	+11 lines, -3 lines	0 comments	Download
M	scripts/slave/unittests/expect_tests/type_definitions.py	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	scripts/slave/unittests/recipe_simulation_test.py	View	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimsh@chromium.org/240053005/1

6 years, 8 months ago (2014-04-17 00:56:31 UTC) #4

Message was sent while issue was closed.

Change committed as 264370

Expand Messages | Collapse Messages