Isolating Chrome Web Store app in the transfer (i.e. non-OpenURL) path.

chrome/browser/extensions/process_management_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/common/chrome_switches.h"
+#include "chrome/common/extensions/api/url_handlers/url_handlers_parser.h"
 #include "chrome/common/extensions/extension_process_policy.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/test_navigation_observer.h"
 #include "extensions/browser/extension_host.h"
+#include "extensions/browser/extension_registry.h"
 #include "extensions/browser/process_manager.h"
+#include "extensions/browser/process_map.h"
+#include "extensions/common/manifest_constants.h"
 #include "extensions/common/switches.h"
+#include "extensions/common/url_pattern.h"
+#include "extensions/common/url_pattern_set.h"
 #include "net/dns/mock_host_resolver.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 
 using content::NavigationController;
 using content::WebContents;
 
 namespace {
 
 class ProcessManagementTest : public ExtensionBrowserTest {
  private:
   // This is needed for testing isolated apps, which are still experimental.
   void SetUpCommandLine(base::CommandLine* command_line) override {
     ExtensionBrowserTest::SetUpCommandLine(command_line);
     command_line->AppendSwitch(
         extensions::switches::kEnableExperimentalExtensionApis);
   }
 };
 
+class ChromeWebStoreProcessTest : public ExtensionBrowserTest {
+ public:
+  const GURL& gallery_url() { return gallery_url_; }
+
+ private:
+  // Overrides location of Chrome Web Store gallery to a test controlled URL.
+  void SetUpCommandLine(base::CommandLine* command_line) override {
+    ExtensionBrowserTest::SetUpCommandLine(command_line);
+
+    ASSERT_TRUE(embedded_test_server()->Start());
+    gallery_url_ =
+        embedded_test_server()->GetURL("chrome.webstore.test.com", "/");
+    command_line->AppendSwitchASCII(switches::kAppsGalleryURL,
+                                    gallery_url_.spec());
+  }
+
+  void SetUpOnMainThread() override {
+    host_resolver()->AddRule("*", "127.0.0.1");
+  }
+
+  GURL gallery_url_;
+};
+
 }  // namespace
 
 
 // TODO(nasko): crbug.com/173137
 #if defined(OS_WIN)
 #define MAYBE_ProcessOverflow DISABLED_ProcessOverflow
 #else
 #define MAYBE_ProcessOverflow ProcessOverflow
 #endif
 
@@ skipping 239 matching lines @@
   EXPECT_EQ(web_url, web_contents->GetLastCommittedURL());
 
   // Verify that the navigation transferred the contents to another renderer
   // process.
   if (extensions::IsIsolateExtensionsEnabled()) {
     content::RenderProcessHost* new_process_host =
         web_contents->GetMainFrame()->GetProcess();
     EXPECT_NE(old_process_host, new_process_host);
   }
 }
+
+IN_PROC_BROWSER_TEST_F(ChromeWebStoreProcessTest,
+                       NavigateWebTabToChromeWebStoreViaPost) {
+  // Navigate a tab to a web page with a form.
+  GURL web_url = embedded_test_server()->GetURL("foo.com", "/form.html");
+  ui_test_utils::NavigateToURL(browser(), web_url);
+  WebContents* web_contents =
+      browser()->tab_strip_model()->GetActiveWebContents();
+  EXPECT_EQ(web_url, web_contents->GetLastCommittedURL());
+  content::RenderProcessHost* old_process_host =
+      web_contents->GetMainFrame()->GetProcess();
+
+  // Note that the |setTimeout| call below is needed to make sure
+  // ExecuteScriptAndExtractBool returns *after* a scheduled navigation has
+  // already started.
+  GURL cws_web_url(gallery_url().spec() + "title1.html");
+  std::string navigation_starting_script =
+      "var form = document.getElementById('form');\n"
+      "form.action = '" + cws_web_url.spec() + "';\n"
+      "form.submit();\n"
+      "setTimeout(\n"
+      "    function() { window.domAutomationController.send(true); },\n"
+      "    0);\n";
+
+  // Trigger a renderer-initiated POST navigation (via the form) to a Chrome Web
+  // Store gallery URL (which will commit into a chrome-extension://cws-app-id).
+  bool ignored_script_result = false;
+  content::TestNavigationObserver nav_observer(web_contents, 1);
+  EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
+      web_contents, navigation_starting_script, &ignored_script_result));
+
+  // Verify that the navigation succeeded.
+  nav_observer.Wait();
+  EXPECT_EQ(cws_web_url, web_contents->GetLastCommittedURL());
+
+  // Verify that we really have the Chrome Web Store app loaded in the Web
+  // Contents.
+  content::RenderProcessHost* new_process_host =
+      web_contents->GetMainFrame()->GetProcess();
+  EXPECT_TRUE(extensions::ProcessMap::Get(profile())->Contains(
+      extensions::kWebStoreAppId, new_process_host->GetID()));
+
+  // Verify that Chrome Web Store is isolated in a separate renderer process.
+  if (extensions::IsIsolateExtensionsEnabled())
+    EXPECT_NE(old_process_host, new_process_host);

[Łukasz Anforowicz, 2016/10/05 22:34:56]

The test expectation above would fail before the changes in the other file
touched by this CL, but it would fail because there would be a renderer kill
before we get here :-)

[136787:136787:1005/152500:ERROR:bad_message.cc(23)] Terminating renderer for
bad IPC message, reason 1
[136787:136787:1005/152500:WARNING:sad_tab.cc(205)] Tab Killed:
http://foo.com:54311/
../../chrome/browser/extensions/process_management_browsertest.cc:371: Failure
Value of: web_contents->GetLastCommittedURL()
  Actual: http://foo.com:54311/form.html
Expected: cws_web_url
Which is: http://chrome.webstore.test.com:54311/title1.html
../../chrome/browser/extensions/process_management_browsertest.cc:378: Failure
Value of: extensions::ProcessMap::Get(profile())->Contains(
extensions::kWebStoreAppId, new_process_host->GetID())
  Actual: false
Expected: true
../../chrome/browser/extensions/process_management_browsertest.cc:382: Failure
Expected: (old_process_host) != (new_process_host), actual: 0x619000166c80 vs
0x619000166c80
[136787:136787:1005/152501:WARNING:url_request_context_getter.cc(43)]
URLRequestContextGetter leaking due to no owning thread.

[lazyboy, 2016/10/05 23:20:02]

Acknowledged.

+}