Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: components/metrics/proto/translate_event.proto

Issue 2400503002: [Translate] Integrate TranslateEventProto UMA logging into TranslateManager. (Closed)
Patch Set: fix trybots Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/test_browser_window.cc ('k') | components/translate/core/browser/translate_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/proto/translate_event.proto
diff --git a/components/metrics/proto/translate_event.proto b/components/metrics/proto/translate_event.proto
index 8dae1b0c01063fc26b7c52d330bfcd0a2b4da1d6..8bba508af402815bfa53938ad5a4be8fc4907fd5 100644
--- a/components/metrics/proto/translate_event.proto
+++ b/components/metrics/proto/translate_event.proto
@@ -111,6 +111,22 @@ message TranslateEventProto {
// The translation was not offered because the URL is not
// supported (e.g. New Tab Page).
UNSUPPORTED_URL = 17;
+ // The previous page was in the same language, so the translate UI was
+ // suppressed.
+ MATCHES_PREVIOUS_LANGUAGE = 18;
+ // The translate UI was not shown because the browser window associated with
+ // the translate event has gone away.
+ BROWSER_WINDOW_IS_INVALID = 19;
+ // The translate UI was not shown because the browser window for the
+ // translate prompt is no longer active.
+ BROWSER_WINDOW_NOT_ACTIVE = 20;
+ // The translate UI was not shown because the browser window is minimized.
+ BROWSER_WINDOW_IS_MINIMIZED = 21;
+ // The translate UI was not shown because the web context for the translate
+ // prompt is no longer active.
+ WEB_CONTENTS_NOT_ACTIVE = 22;
+ // The translate UI was not shown because the user is editing a form field.
+ EDITABLE_FIELD_IS_ACTIVE = 23;
}
// Event received from translate UI.
@@ -131,4 +147,4 @@ message TranslateEventProto {
// Modified target language, if the user changed it. If changed more than
// once, we only keep the last one.
optional string modified_target_language = 13;
-}
+}
« no previous file with comments | « chrome/test/base/test_browser_window.cc ('k') | components/translate/core/browser/translate_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698