chrome/browser/ui/cocoa/browser_window_cocoa.h - Issue 2400503002: [Translate] Integrate TranslateEventProto UMA logging into TranslateManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.h

Issue 2400503002: [Translate] Integrate TranslateEventProto UMA logging into TranslateManager. (Closed)

Patch Set: plumb through to TranslateBubbleUiEvent UMA metric Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_cocoa.h

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.h b/chrome/browser/ui/cocoa/browser_window_cocoa.h

index 9547f550e6ad0902838b35677d07ec813d2e0508..1f44b4ad9539edc5dd9e132efba4e1c37fba71cb 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.h

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.h

@@ -108,10 +108,11 @@ class BrowserWindowCocoa

content::WebContents* contents,

autofill::SaveCardBubbleController* controller,

bool user_gesture) override;

- void ShowTranslateBubble(content::WebContents* contents,

- translate::TranslateStep step,

- translate::TranslateErrors::Type error_type,

- bool is_user_gesture) override;

+ ShowTranslateBubbleResult ShowTranslateBubble(

+ content::WebContents* contents,

+ translate::TranslateStep step,

+ translate::TranslateErrors::Type error_type,

+ bool is_user_gesture) override;

#if BUILDFLAG(ENABLE_ONE_CLICK_SIGNIN)

void ShowOneClickSigninConfirmation(

const base::string16& email,