Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2650)

Unified Diff: chrome/browser/ui/browser_window.h

Issue 2400503002: [Translate] Integrate TranslateEventProto UMA logging into TranslateManager. (Closed)
Patch Set: plumb through to TranslateBubbleUiEvent UMA metric Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_window.h
diff --git a/chrome/browser/ui/browser_window.h b/chrome/browser/ui/browser_window.h
index 46d3a952c89777ae735a24d4a5145084d8a7745d..ed18f8853b2c06dd050f439e5087ef9441545789 100644
--- a/chrome/browser/ui/browser_window.h
+++ b/chrome/browser/ui/browser_window.h
@@ -68,6 +68,15 @@ class WebContentsModalDialogHost;
enum class ImeWarningBubblePermissionStatus;
+enum class ShowTranslateBubbleResult {
+ SUCCESS,
+ BROWSER_WINDOW_NOT_VALID,
groby-ooo-7-16 2016/11/15 01:15:43 Probably worth a quick comment that all cases exce
Roger McFarlane (Chromium) 2016/11/16 05:51:31 Done.
+ BROWSER_WINDOW_MINIMIZED,
+ BROWSER_WINDOW_NOT_ACTIVE,
+ WEB_CONTENTS_NOT_ACTIVE,
+ EDITABLE_FIELD_IS_ACTIVE,
+};
+
////////////////////////////////////////////////////////////////////////////////
// BrowserWindow interface
// An interface implemented by the "view" of the Browser window.
@@ -242,7 +251,7 @@ class BrowserWindow : public ui::BaseWindow {
//
// |is_user_gesture| is true when the bubble is shown on the user's deliberate
// action.
- virtual void ShowTranslateBubble(
+ virtual ShowTranslateBubbleResult ShowTranslateBubble(
content::WebContents* contents,
translate::TranslateStep step,
translate::TranslateErrors::Type error_type,

Powered by Google App Engine
This is Rietveld 408576698