[Translate] Integrate TranslateEventProto UMA logging into TranslateManager.

chrome/browser/ui/browser_commands.cc

Index: chrome/browser/ui/browser_commands.cc
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index c612bc7f27494e29f8092bdf71b258ac17763e77..726ddad9d9fc5a9b6cc46ddc98a5e2a76ded685b 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -51,6 +51,7 @@
 #include "chrome/browser/ui/tab_contents/core_tab_helper.h"
 #include "chrome/browser/ui/tab_dialogs.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/translate/translate_bubble_view_state_transition.h"
 #include "chrome/browser/upgrade_detector.h"
 #include "chrome/common/content_restriction.h"
 #include "chrome/common/features.h"
@@ -827,8 +828,11 @@ void Translate(Browser* browser) {
     else if (chrome_translate_client->GetLanguageState().IsPageTranslated())
       step = translate::TRANSLATE_STEP_AFTER_TRANSLATE;
   }
-  browser->window()->ShowTranslateBubble(
+  ShowTranslateBubbleResult result = browser->window()->ShowTranslateBubble(
       web_contents, step, translate::TranslateErrors::NONE, true);
+  if (result != ShowTranslateBubbleResult::SUCCESS) {

[sky, 2016/11/11 19:07:40]

no {}

[Roger McFarlane (Chromium), 2016/11/11 19:55:09]

Done.

+    translate::ReportUiAction(translate::BUBBLE_REQUESTED_BUT_NOT_SHOWN);

[sky, 2016/11/11 19:07:40]

How come you don't pass through result here?

[Roger McFarlane (Chromium), 2016/11/11 19:55:09]

Done.

This required expanding the translate::TranslateBubbleUiEvent enum and
corresponding histograms.xml declaration.

+  }
 }
 
 void ManagePasswordsForPage(Browser* browser) {